Help with code

[StealthBomber]

Okay so I set up a new national decision and event modifier "Establish_Military_Academy" and added a new trait strategist. So what ive been trying to do is this. When a character becomes an ex civic tech I want him to acquire the strategist trait. So far I can't get it to work hence why I am here. All I have managed to do is give it to every one if any one could help I would much appreciate it.

	Establish_Military_Academy = {
		potential = {
			tag = ROM
			not = { has_country_modifier = Establish_Military_Academy }
		}
		
		allow = {
		ruler = { martial = 1
			}
			}
			
		effect = {
		any_character = {
			OR = {
				has_title = title_ex_civic_tech
			 }
			add_trait = strategist
			}
			stability = -3
			add_country_modifier = {
				name = "Establish_Military_Academy"
				duration = -1
			}
		}
		revoke_allowed = {
			always = no
		}
}

 

[alania_ckdv]

Okay so I set up a new national decision and event modifier "Establish_Military_Academy" and added a new trait strategist. So what ive been trying to do is this. When a character becomes an ex civic tech I want him to acquire the strategist trait. So far I can't get it to work hence why I am here. All I have managed to do is give it to every one if any one could help I would much appreciate it.

    Establish_Military_Academy = {
        potential = {
            tag = ROM
            not = { has_country_modifier = Establish_Military_Academy }
        }
       
        allow = {
        ruler = { martial = 1
            }
            }
           
        effect = {
        any_character = {
            OR = {
                has_title = title_ex_civic_tech
             }
            add_trait = strategist
            }
            stability = -3
            add_country_modifier = {
                name = "Establish_Military_Academy"
                duration = -1
            }
        }
        revoke_allowed = {
            always = no
        }
}

Do the new trait (strategist) and new modifier (Establish_Military_Academy) work?
Did you examine each independently?

If yes, change the any_character section of effect as below

any_character = {
limit = { has_title = title_ex_civic_tech }
add_trait = strategist
}

I tested resembled decision using raised_tax modifier, title_civic_tech, and victorious trait, and it seemed to work. But I found that this effect is one-time (i.e., next civic_tech did not have victorious in my test).
If you mean a kind of school, I think it is better to make a character_event giving ex_civic_tech strategist under Establish_Military_Academy modifier.