my "criteria" and my reasoning is gameplay reasons. These regions could very well have fallen under Japenese control before war broke out, which is impossible to represent if they were directly under KMT control in HOI4. Suiyuan and Shantung (and heck even Shanxi) based on everything I read had a great deal of autonomy and were courted by the Japanese on multiple occasions. Party membership in China is only one of many factors.
The basic situation in China after the Xi'an incident was that no more large-scale incursions could occur without war: there weren't going to be any more provinces lopped off China. The entire reason that Chiang pushed the Japanese in Shanghai after the Marco Polo bridge incident was to make this clear to the Japanese. Is suppose Chiang could have made more concessions in the North, but he wouldn't have be leader for much longer if he had, and these concessions are perfectly model-able through events.
I have no idea where that map comes from, but it is both old (judging by the Wade-Giles Romanisation system used) and inaccurate/uses weasel terms like "largely autonomous", "virtually independent". Suiyuan wasn't "Independent of Nanjing", it was governed by Yan Xishan who was ultimately a KMT member who followed Chiang's orders, and defended by KMT troops, and eventually seized by the Japanese after the Marco Polo bridge incident and integrated (along with Chahar) into Mengjiang. It shows a "Japan sponsored puppet state 1935" embracing Hebei, Shandong, Suiyuan, and Shanxi, but this is actually the state the Japanese
wished to establish in 1935, not one they
did establish in 1935, though of course once these areas (largely, the Japanese never took all of Shanxi) fell into their hand they nominally came within the area governed by their puppet governments.
"official" autonomy is irrelevant. what matters is in practice. "de facto"
Obviously it does matter, as if an area is at least nominally autonomous, then the working assumption is that it is autonomous unless there's evidence to the contrary. If, on the other hand, no de jure autonomy exists, then you assume that it wasn't autonomous unless there's evidence to the contrary. I the case of the warlords, they had all sworn allegiance to the KMT and were de jure under Chiang's leadership.
Obeying orders is not autonomy.
Very obviously someone who directly follows another's orders (like the warlords followed Chiang's orders) then that's a strong indicator that they weren't really all that autonomous.
Degree of top down control determines autonomy.
Like the way the Guangxi warlords followed Chiang's orders in the Battle of Shanghai? Or the way the Qinghai warlords followed his orders in the fighting against the Communists in the 1930's?
Basing troops in a region is not an argument against autonomy.
If the supreme government can move troops at will through a territory, that's a good indicator that that territory is not really independent.
In HOI4, a puppet country can have the mother country station troops there. Remember this is not some academic or philosophical debate, this is how to represent history within the mechanics of HOI4.
Yes, and history tells us that the warlords ultimately had none of the characteristics of independent states, not even nominally.
As for Li Zongren and Liu Wenhui...how about throwing out some justifications or explanations instead of just stating there names in some pedantic show of intelligence? I'm trying to make this game better, not show off my knowledge. So I appreciate only that criticism that helps
Their biographies are online - so rather than flying off the handle, why not give them a read? You can see that they were warlords, but followed Chiang's orders. You can see that there were people who could fairly be described as warlords throughout China at that time, and that making the warlords into independent states would result in China basically not existing. You can see that it really doesn't make that much sense to have some warlord-run areas run directly by the KMT but others not since they were just as likely to scheme against Chiang (and each other).
My main issue here is that modelling the Chinese warlords as independent states (or even as puppets) resulted in HOI3 in:
1) An inability to ever unify China as the KMT without going to war. In reality, if Chiang wanted to get rid of the warlords he could, though he would often rely on assassination to achieve this.
2) A lack of the historical level of control over warlord troops.
3) Warlords carrying out diplomatic relations.
4) Foreign countries attacking warlords without finding themselves at war with the KMT (and vice-versa).
I'd prefer just to do away with them and simulate the disunity and inefficiency/low morale they caused with maluses.