What... this is cursed

[Cyanitem]

So I was invading poland as germany and took warsaw and this message popped

 

[bitmode]

You briefly lost control of Warsaw during your attack. Despite what the text says, the news can be triggered by either the Soviet Union or Poland.

 

[Louella]

announcements can be weird.

I got this one, playing as the UK, when war broke out:

 

[bitmode]

announcements can be weird.

I got this one, playing as the UK, when war broke out:
View attachment 666889

The trigger looks like this:

    mean_time_to_happen = { days = 2 }
    trigger = {
        any_country = {
            has_naval_treaty_trigger = yes
            has_war = yes
            any_enemy_country = {
                is_major = yes
                NOT = { tag = event_target:WTT_current_china_leader} #special exception
            }
        }
    }

This is weird not just on one level:

• A MTTH of 2 days has no effect (https://hoi4.paradoxwikis.com/Event_modding#mean_time_to_happen)
• wrapping the trigger in any_country is not necessary (and bad for performance) because every country evaluates it anyway. Currently, half a dozen countries each day check the conditions for every country that exists.
• has_war = yes is covered by the next check. It is also not effective as an early out in the most common case of peace because any_enemy_country's small overhead in that case is less than what has_war does.
• there is no need to trigger through an event at all, because there are actions for that:

on_actions = {
  on_declare_war = {  # ROOT = attacker, FROM = defender
    if = {
      limit = {
        is_major = yes
        not = { tag = event_target:WTT_current_china_leader} #special exception
        FROM = { has_naval_treaty_trigger = yes }
      }
      FROM = { effects... }
    }
    else_if = {
      limit = {
        FROM = {
          is_major = yes
          not = { tag = event_target:WTT_current_china_leader} #special exception
        }
        has_naval_treaty_trigger = yes
      }
      effects...
    }
  }
}