[VV] Clan chiefs wrongly complain about their family not having jobs

[ElectricEel]

There's an event where one of a tribe's clan chiefs complains that no one in his family has a job. This event can fire even if some of the clan chief's family members *do* have jobs. I've had it fire while the chief has family members in the position of a naval commander or a tech advisor.

Here's the relevant part of the event (from 'internal_politics_tribe.txt', ID 3543):

trigger = {
		country = {
			government = tribal
		}
		is_clan_chief = yes
		NOT = {
			any_family_member = {
				has_job = no
			}
		}
}

Doesn't the 'NOT' argument actually return true only if none of the conditions within are met? If that's the case, that condition is actually a double negative - it will only let the event fire if a family member of the clan chief does not *not* have a job, just the opposite of the intended effect.

If I'm correct, simply changing the condition from 'has_job = no' to 'has_job = yes' should solve the problem.

trigger = {
		country = {
			government = tribal
		}
		is_clan_chief = yes
		NOT = {
			any_family_member = {
				has_job = yes
			}
		}
}

 

[Silktrader]

Yes, the bug was caught as soon as released. It's quite an irritating issue, given the MTTH.

As for the trigger conditions, You are correct - that's where the issue lays. Though the fix will be slightly different than You suggested.

(Your bug report was exemplary, tidy and clear.)

 

[ElectricEel]

...Though the fix will be slightly different than You suggested.

That's good, since it turns out my attemp didn't actually work - the event occurred again even though a family member of the clan chief it triggered for was working as a tech advisor. I'll just comment out the event while I wait for an official fix.

 

[richtern]

Does the "any_family_member" command identify the clan chief themselves as a family member?

I have had instances where the clan chief complains about the family not having any jobs even though the one family member that has a job is the clan chief themselves. This is most likely due to the script error up above but I would like to make sure.