Victoria III - [GAMEPLAY] [MODDING] Missing multiplicative output modifiers for certain goods in 00_building_modifier_types.txt

[Chief of Staff]

Short summary of your issue
[GAMEPLAY] [MODDING] Missing multiplicative output modifiers for certain goods in 00_building_modifier_types.txt

Game Version
1.0.6

What OS are you playing on?
Windows

Do you have mods enabled?
Yes

Have you tried verifying your game files?
No

How much "pain" is this causing you?
3

Please explain the issue you experienced in the most condensed way possible
Not a bug per se but a possible oversight which I am not sure where to report so my apologies if this is inappropriate place to report them. Please let me know where I should report this if this is not the place. In /game/common/modifier_types/00_building_modifier_types.txt, there is no multiplicative output modifiers defined for grain and rubber like other certain goods.

For example, building_output_oil_mult is defined in this file but building_output_grain_mult or building_output_rubber_mult are not. There may be additional goods that lacked such modifiers. Have not yet tried them in my mod yet but I suspect they are unlikely to work. Either way, even if they work, I suspect their omissions from this file is probably an oversight.

I should note that there are building_output_grain_add and building_output_rubber_add defined in this file but these are additive, not multiplicative.

Please explain how to reproduce the issue
N/A. See above

Is there anything else you think could help us identify/replicate the issue?
N/A.

I have attached a save game
No

Upload Attachment
File(s) attached

 

[Chief of Staff]

P.S. This sub-forum would not allow me to submit this report without an attachment so I was forced to attach a game file which you obviously can already access. Sorry about that duplicate but I had no choice.

 

[Nosferatu44]

building_output_small_arms_mult
building_output_artillery_mult
building_output_tanks_mult
building_output_aeroplanes_mult
building_output_manowars_mult
building_output_ironclads_mult

building_output_fabric_mult
building_output_electricity_mult
building_output_clippers_mult
building_output_steamers_mult
building_output_silk_mult
building_output_hardwood_mult
building_output_oil_mult
building_output_engines_mult
building_output_tools_mult

building_output_fruit_mult
building_output_liquor_mult
building_output_wine_mult
building_output_sugar_mult
building_output_automobile_mult

only those are availibe for now, dont know why others are not working
grain, fish, wood, groceries, clothes, furniture, paper, services, transportation, dye, sulfur, coal, iron, lead, rubber, steel, glass, fertilizer, explosives, porcelain, meat, tea, coffee, tobacco, opium, telephones, radios, luxury_clothes, luxury_furniture, fine_art
those goods are missing building_output_{goods}_mult modifiers

 

[Nosferatu44]

Anyway, if you wanna add a new modifier, you can create building_modifier_types yourself.
create a 01_building_modifier_types.txt file in

Victoria 3\game\common\modifier_types

and add new building output modifier in following format

building_output_{good_type}_mult = {
    good = yes
    percent = yes
}

Here is the modifiers that I created for myself with all type of goods

# 军需品 #
building_output_ammunition_mult = {
    good = yes
    percent = yes
}
building_output_small_arms_mult = {
    good = yes
    percent = yes
}
building_output_artillery_mult = {
    good = yes
    percent = yes
}
building_output_tanks_mult = {
    good = yes
    percent = yes
}
building_output_aeroplanes_mult = {
    good = yes
    percent = yes
}
building_output_manowars_mult = {
    good = yes
    percent = yes
}
building_output_ironclads_mult = {
    good = yes
    percent = yes
}

# 消费品 #
building_output_grain_mult = {
    good = yes
    percent = yes
}
building_output_fish_mult = {
    good = yes
    percent = yes
}
building_output_fabric_mult = {
    good = yes
    percent = yes
}
building_output_wood_mult = {
    good = yes
    percent = yes
}
building_output_groceries_mult = {
    good = yes
    percent = yes
}
building_output_clothes_mult = {
    good = yes
    percent = yes
}
building_output_furniture_mult = {
    good = yes
    percent = yes
}
building_output_paper_mult = {
    good = yes
    percent = yes
}
building_output_services_mult = {
    good = yes
    percent = yes
}
building_output_transportation_mult = {
    good = yes
    percent = yes
}
building_output_electricity_mult = {
    good = yes
    percent = yes
}

# 工业品 #
building_output_clippers_mult = {
    good = yes
    percent = yes
}
building_output_steamers_mult = {
    good = yes
    percent = yes
}
building_output_silk_mult = {
    good = yes
    percent = yes
}
building_output_dye_mult = {
    good = yes
    percent = yes
}
building_output_sulfur_mult = {
    good = yes
    percent = yes
}
building_output_coal_mult = {
    good = yes
    percent = yes
}
building_output_iron_mult = {
    good = yes
    percent = yes
}
building_output_lead_mult = {
    good = yes
    percent = yes
}
building_output_hardwood_mult = {
    good = yes
    percent = yes
}
building_output_rubber_mult = {
    good = yes
    percent = yes
}
building_output_oil_mult = {
    good = yes
    percent = yes
}
building_output_engines_mult = {
    good = yes
    percent = yes
}
building_output_steel_mult = {
    good = yes
    percent = yes
}
building_output_glass_mult = {
    good = yes
    percent = yes
}
building_output_fertilizer_mult = {
    good = yes
    percent = yes
}
building_output_tools_mult = {
    good = yes
    percent = yes
}
building_output_explosives_mult = {
    good = yes
    percent = yes
}

# 奢侈品 #
building_output_porcelain_mult = {
    good = yes
    percent = yes
}
building_output_meat_mult = {
    good = yes
    percent = yes
}
building_output_fruit_mult = {
    good = yes
    percent = yes
}
building_output_liquor_mult = {
    good = yes
    percent = yes
}
building_output_wine_mult = {
    good = yes
    percent = yes
}
building_output_tea_mult = {
    good = yes
    percent = yes
}
building_output_coffee_mult = {
    good = yes
    percent = yes
}
building_output_sugar_mult = {
    good = yes
    percent = yes
}
building_output_tobacco_mult = {
    good = yes
    percent = yes
}
building_output_opium_mult = {
    good = yes
    percent = yes
}
building_output_automobiles_mult = {
    good = yes
    percent = yes
}
building_output_telephones_mult = {
    good = yes
    percent = yes
}
building_output_radios_mult = {
    good = yes
    percent = yes
}
building_output_luxury_clothes_mult = {
    good = yes
    percent = yes
}
building_output_luxury_furniture_mult = {
    good = yes
    percent = yes
}
building_output_gold_mult = {
    good = yes
    percent = yes
}
building_output_fine_art_mult = {
    good = yes
    percent = yes
}

Be aware, new modifier will missing the localization so you need to create it yourself

 

[Chief of Staff]

Anyway, if you wanna add a new modifier, you can create building_modifier_types yourself.
create a 01_building_modifier_types.txt file in

Victoria 3\game\common\modifier_types

and add new building output modifier in following format

building_output_{good_type}_mult = {
    good = yes
    percent = yes
}

Here is the modifiers that I created for myself with all type of goods

# 军需品 #
building_output_ammunition_mult = {
    good = yes
    percent = yes
}
building_output_small_arms_mult = {
    good = yes
    percent = yes
}
building_output_artillery_mult = {
    good = yes
    percent = yes
}
building_output_tanks_mult = {
    good = yes
    percent = yes
}
building_output_aeroplanes_mult = {
    good = yes
    percent = yes
}
building_output_manowars_mult = {
    good = yes
    percent = yes
}
building_output_ironclads_mult = {
    good = yes
    percent = yes
}

# 消费品 #
building_output_grain_mult = {
    good = yes
    percent = yes
}
building_output_fish_mult = {
    good = yes
    percent = yes
}
building_output_fabric_mult = {
    good = yes
    percent = yes
}
building_output_wood_mult = {
    good = yes
    percent = yes
}
building_output_groceries_mult = {
    good = yes
    percent = yes
}
building_output_clothes_mult = {
    good = yes
    percent = yes
}
building_output_furniture_mult = {
    good = yes
    percent = yes
}
building_output_paper_mult = {
    good = yes
    percent = yes
}
building_output_services_mult = {
    good = yes
    percent = yes
}
building_output_transportation_mult = {
    good = yes
    percent = yes
}
building_output_electricity_mult = {
    good = yes
    percent = yes
}

# 工业品 #
building_output_clippers_mult = {
    good = yes
    percent = yes
}
building_output_steamers_mult = {
    good = yes
    percent = yes
}
building_output_silk_mult = {
    good = yes
    percent = yes
}
building_output_dye_mult = {
    good = yes
    percent = yes
}
building_output_sulfur_mult = {
    good = yes
    percent = yes
}
building_output_coal_mult = {
    good = yes
    percent = yes
}
building_output_iron_mult = {
    good = yes
    percent = yes
}
building_output_lead_mult = {
    good = yes
    percent = yes
}
building_output_hardwood_mult = {
    good = yes
    percent = yes
}
building_output_rubber_mult = {
    good = yes
    percent = yes
}
building_output_oil_mult = {
    good = yes
    percent = yes
}
building_output_engines_mult = {
    good = yes
    percent = yes
}
building_output_steel_mult = {
    good = yes
    percent = yes
}
building_output_glass_mult = {
    good = yes
    percent = yes
}
building_output_fertilizer_mult = {
    good = yes
    percent = yes
}
building_output_tools_mult = {
    good = yes
    percent = yes
}
building_output_explosives_mult = {
    good = yes
    percent = yes
}

# 奢侈品 #
building_output_porcelain_mult = {
    good = yes
    percent = yes
}
building_output_meat_mult = {
    good = yes
    percent = yes
}
building_output_fruit_mult = {
    good = yes
    percent = yes
}
building_output_liquor_mult = {
    good = yes
    percent = yes
}
building_output_wine_mult = {
    good = yes
    percent = yes
}
building_output_tea_mult = {
    good = yes
    percent = yes
}
building_output_coffee_mult = {
    good = yes
    percent = yes
}
building_output_sugar_mult = {
    good = yes
    percent = yes
}
building_output_tobacco_mult = {
    good = yes
    percent = yes
}
building_output_opium_mult = {
    good = yes
    percent = yes
}
building_output_automobiles_mult = {
    good = yes
    percent = yes
}
building_output_telephones_mult = {
    good = yes
    percent = yes
}
building_output_radios_mult = {
    good = yes
    percent = yes
}
building_output_luxury_clothes_mult = {
    good = yes
    percent = yes
}
building_output_luxury_furniture_mult = {
    good = yes
    percent = yes
}
building_output_gold_mult = {
    good = yes
    percent = yes
}
building_output_fine_art_mult = {
    good = yes
    percent = yes
}

Be aware, new modifier will missing the localization so you need to create it yourself

Whoops, I almost forgot about this thread. But, yes, it is possible to add them via modifier_types, as I already found out.

As for the localization, here is what I got so far:

 # Modifier types
 modifier_building_output_grain_mult:0 "Building @grain! Grain output"
 modifier_building_output_grain_mult_desc:0 "A bonus or penalty to the amount of @grain! Grain produced by buildings"
 modifier_building_output_rubber_mult:0 "Building @rubber! Rubber output"
 modifier_building_output_rubber_mult_desc:0 "A bonus or penalty to the amount of @rubber! Rubber produced by buildings"
 modifier_building_output_iron_mult:0 "Building @iron! Iron output"
 modifier_building_output_iron_mult_desc:0 "A bonus or penalty to the amount of @iron! Iron produced by buildings"
 modifier_building_output_coal_mult:0 "Building @coal! Coal output"
 modifier_building_output_coal_mult_desc:0 "A bonus or penalty to the amount of @coal! Coal produced by buildings"
 modifier_building_output_wood_mult:0 "Building @wood! Wood output"
 modifier_building_output_wood_mult_desc:0 "A bonus or penalty to the amount of @wood! Wood produced by buildings"
 modifier_building_output_sulfur_mult:0 "Building @sulfur! Sulfur output"
 modifier_building_output_sulfur_mult_desc:0 "A bonus or penalty to the amount of @sulfur! Sulfur produced by buildings"
 modifier_building_output_lead_mult:0 "Building @lead! Lead output"
 modifier_building_output_lead_mult_desc:0 "A bonus or penalty to the amount of @lead! Lead produced by buildings"
 modifier_building_output_fertilizer_mult:0 "Building @fertilizer! Fertilizer output"
 modifier_building_output_fertilizer_mult_desc:0 "A bonus or penalty to the amount of @fertilizer! Fertilizer produced by buildings"
 modifier_building_output_opium_mult:0 "Building @opium! Opium output"
 modifier_building_output_opium_mult_desc:0 "A bonus or penalty to the amount of @opium! Opium produced by buildings"

I copied over from vanilla localization and just replace with the goods name. I used "Replace..." dialog (Ctrl+H) in Notepad3 to replace all text (using "match case" option for "opium" and "Opium" for example). Hope that helps you if you have not yet figured out the localization part yet or if you think this is better than what you got so far.