Short summary of your issue
1.1.2 : On_War_Begins can incorrectly fire when a white peace is signed
Game Version
1.1.2
What OS are you playing on?
Windows
Do you have mods enabled?
No
Have you tried verifying your game files?
Yes
How much "pain" is this causing you?
6
Please explain the issue you experienced in the most condensed way possible
In this save, there was an Indian uprising in Ceylon against East India Company using the dp_secession diplomatic play. I backed the rebels and Qing backed EIC. At this point, both the rebels and EIC have capitulated and Qing is willing to accept a white peace.
The problem is that when the white peace is signed, on_war_begins is triggered for dp_secession, which triggers all the effects in that block. I noticed this because I had modded dp_secession to have effects in on_war_begins. On_war_begins should NOT be firing when a white peace is signed, it should only fire when the war starts.
For ease of reference, I have included mods in the save so that you can see for yourself that all effects under on_war_begins is triggered when the white peace is signed.
Please explain how to reproduce the issue
1. Offer white peace to Qing
2. When the white peace is signed, all effects in on_war begins will be triggered, this will add a modifier called "Revolutionary country" and a journal entry. on_war_begins should NOT be triggering when a white peace is signed.
Is there anything else you think could help us identify/replicate the issue?
For reference, here is the code for on_war_begins in the mod test, for dp_secession :
This is triggered when the white peace is signed, which should not be happening. Scope:target should not even be scoping to Scandinavia as the scope:target should be the Indian uprising (the country seceding from EIC). I suspect that EIC and the rebels capitulating early may have caused problems with the scope, but fundamentally, on_war_begins should only fire when the war begins, not when a white peace is signed.
I have attached a save game
Yes
Upload Attachment
File(s) attached
1.1.2 : On_War_Begins can incorrectly fire when a white peace is signed
Game Version
1.1.2
What OS are you playing on?
Windows
Do you have mods enabled?
No
Have you tried verifying your game files?
Yes
How much "pain" is this causing you?
6
Please explain the issue you experienced in the most condensed way possible
In this save, there was an Indian uprising in Ceylon against East India Company using the dp_secession diplomatic play. I backed the rebels and Qing backed EIC. At this point, both the rebels and EIC have capitulated and Qing is willing to accept a white peace.
The problem is that when the white peace is signed, on_war_begins is triggered for dp_secession, which triggers all the effects in that block. I noticed this because I had modded dp_secession to have effects in on_war_begins. On_war_begins should NOT be firing when a white peace is signed, it should only fire when the war starts.
For ease of reference, I have included mods in the save so that you can see for yourself that all effects under on_war_begins is triggered when the white peace is signed.
Please explain how to reproduce the issue
1. Offer white peace to Qing
2. When the white peace is signed, all effects in on_war begins will be triggered, this will add a modifier called "Revolutionary country" and a journal entry. on_war_begins should NOT be triggering when a white peace is signed.
Is there anything else you think could help us identify/replicate the issue?
For reference, here is the code for on_war_begins in the mod test, for dp_secession :
Code:
on_war_begins = {
scope:target = {
every_scope_state = {
limit = {
is_incorporated = yes
}
add_loyalists = { value = 1 }
}
add_modifier = {
name = revolutionary_modifier
}
add_journal_entry = { type = je_test_revolution }
}
}
This is triggered when the white peace is signed, which should not be happening. Scope:target should not even be scoping to Scandinavia as the scope:target should be the Indian uprising (the country seceding from EIC). I suspect that EIC and the rebels capitulating early may have caused problems with the scope, but fundamentally, on_war_begins should only fire when the war begins, not when a white peace is signed.
I have attached a save game
Yes
Upload Attachment
File(s) attached