Unable to scope to mining/research stations

[AvatarPrime]

This may be a bug, I wanted to check here first.

Running 2.1.2 170f, all dlc except distant stars.

I'm working on a mod and I'm unable to scope to any mining or research stations. I've tried random_mining_station and every_mining_station at country, system, and planet scopes and it never seems to find anything.

Here's an example. Inside the player's starting system scope, I've tried several variants of this code block:

every_system_planet = {

                        log = "[This.GetName]"
                        if = {
                            limit = { has_mining_station = yes }
                            log = "[This.GetName] has a mining station"
                            random_mining_station = { dismantle = yes }
                        }
                        if = {
                            limit = { has_research_station = yes }
                            log = "[This.GetName] has a research station"
                            random_research_station = { dismantle = yes }
                        }

                        random_mining_station = {
                            log = "[This.GetName] is a mining station"
                        }
}

The log calls are being used to check to see if any mining/research stations are being found. In the output, all of the planet names appear, but the stations never do. Likewise, effects applied to stations inside the code do not execute. The error log doesn't show any errors.

 

[Courageous]

I would say that if you are indeed successfully printing out the planet's name on that top log entry, and that the starting system does have orbital mining stations (which generally they do), you do appear to have a bug. Wierd, tho. Also, several vanilla files execute similar code.

What happens if you run this code against every_planet in the galaxy?

 

[Persepheus]

when do you call that script?
iirc the stations in the starting system are created relatively late.

 

[Courageous]

> iirc the stations in the starting system are created relatively late.

Fairly good point, that. Do we know when player on_actions are called relative to base game ones? Starting countries are inited from game_start.33, which is called from on_game_start_country (from vanilla/common/on_actions.txt).

I can imagine an edge case: if the game processess vanilla and player on_game start, and then processes vanilla and player on_game_start_country, then any event called from on_game_start (even if player) would precede all on_game_start_countries. That may be what we are seeing here.

 

[AvatarPrime]

when do you call that script?
iirc the stations in the starting system are created relatively late.

Good catch. I think you're right. The event was originally placed at the start of on_game_start_country. I moved it to the end and was able to find the stations, but effects still aren't working.

               if = {
                   limit = { has_mining_station = yes }
                   log = "[This.GetName] has a mining station"
                   random_mining_station = {
                       log = "[This.GetName]"
                       dismantle = yes
                   }
               }

This block (now at the end of on_game_start_country) will show the station name in the log, but the dismantle effect doesn't seem to do anything. I've tried several other kill effects but the station always remains.

 

[Courageous]

Very odd; dismantle = yes appears in a good 15 times or so in vanilla code.

 

[AvatarPrime]

My guess is that the problem is either in the type of event or the timing (on_game_start, etc.), since it seems to work once the game is running.