These events just won't fire

[Daelyn75]

I have edited them and re-edited them many times, the game loads plays as normal but the events just refuse to fire for the USA. Anyone see why its not firing?

#########################################################################
# Industrial Production Increased 1943 Part one
#########################################################################
event = {
id = 3889
random = no
country = USA

trigger = {
war = { country = USA country = GER }
war = { country = USA country = JAP }
OR = {
war = { country = USA country = SOV }
}
}

name = "Industrial Production Increased for the new Year"
desc = "More spending, new factories, and more existing factories totally focused on the war effort, everyones doing their part!"
picture = "factory"
style = 0

date = { day = 1 month = january year = 1943 }
offset = 1 # Check for this every day
deathdate = { day = 30 month = december year = 1947 }

action_a = {
name = "The American Eagle's wings have unfurled!"
command = { type = construct which = ic where = 602 value = 8 }
command = { type = metalpool value = 20 where = 602 }
command = { type = energypool value = 20 where = 602 }
command = { type = rarematerialspool value = 10 where = 602 }
command = { type = construct which = ic where = 762 value = 5 }
command = { type = metalpool value = 20 where = 762 }
command = { type = energypool value = 20 where = 762 }
command = { type = rarematerialspool value = 10 where = 762 }
command = { type = construct which = ic where = 765 value = 3 }
command = { type = metalpool value = 20 where = 765 }
command = { type = energypool value = 20 where = 765 }
command = { type = rarematerialspool value = 10 where = 765 }
command = { type = construct which = ic where = 600 value = 4 }
command = { type = metalpool value = 20 where = 600 }
command = { type = energypool value = 20 where = 600 }
command = { type = rarematerialspool value = 10 where = 600 }
command = { type = construct which = ic where = 620 value = 7 }
command = { type = metalpool value = 20 where = 620 }
command = { type = energypool value = 20 where = 620 }
command = { type = rarematerialspool value = 10 where = 620 }
command = { type = construct which = ic where = 616 value = 6 }
command = { type = metalpool value = 20 where = 616 }
command = { type = energypool value = 20 where = 616 }
command = { type = rarematerialspool value = 10 where = 616 }
command = { type = construct which = ic where = 606 value = 4 }
command = { type = metalpool value = 20 where = 606 }
command = { type = energypool value = 20 where = 606 }
command = { type = rarematerialspool value = 10 where = 606 }
command = { type = construct which = ic where = 608 value = 5 }
command = { type = metalpool value = 20 where = 608 }
command = { type = energypool value = 20 where = 608 }
command = { type = rarematerialspool value = 10 where = 608 }
command = { type = construct which = ic where = 780 value = 3 }
command = { type = metalpool value = 20 where = 780 }
command = { type = energypool value = 20 where = 780 }
command = { type = rarematerialspool value = 10 where = 780 }
command = { type = construct which = ic where = 603 value = 5 }
command = { type = metalpool value = 20 where = 603 }
command = { type = energypool value = 20 where = 603 }
command = { type = rarematerialspool value = 10 where = 603 }
command = { type = industrial_modifier which = total value = 15 }
}
}


#########################################################################
# Industrial Production Increased 1944 Part two
#########################################################################
event = {
id = 3890
random = no
country = USA

trigger = {
war = { country = USA country = GER }
war = { country = USA country = JAP }
OR = {
war = { country = USA country = SOV }
}
}

name = "Industrial Production Increased for the new Year"
desc = "The Sleeping Giant has awakened"
picture = "factory"
style = 0

date = { day = 1 month = january year = 1944 }
offset = 1 # Check for this every day
deathdate = { day = 30 month = december year = 1947 }

action_a = {
name = "Buy warbonds!"
command = { type = construct which = ic where = 602 value = 8 }
command = { type = metalpool value = 20 where = 602 }
command = { type = energypool value = 20 where = 602 }
command = { type = rarematerialspool value = 10 where = 602 }
command = { type = construct which = ic where = 762 value = 5 }
command = { type = metalpool value = 20 where = 762 }
command = { type = energypool value = 20 where = 762 }
command = { type = rarematerialspool value = 10 where = 762 }
command = { type = construct which = ic where = 765 value = 3 }
command = { type = metalpool value = 20 where = 765 }
command = { type = energypool value = 20 where = 765 }
command = { type = rarematerialspool value = 10 where = 765 }
command = { type = construct which = ic where = 600 value = 4 }
command = { type = metalpool value = 20 where = 600 }
command = { type = energypool value = 20 where = 600 }
command = { type = rarematerialspool value = 10 where = 600 }
command = { type = construct which = ic where = 620 value = 7 }
command = { type = metalpool value = 20 where = 620 }
command = { type = energypool value = 20 where = 620 }
command = { type = rarematerialspool value = 10 where = 620 }
command = { type = construct which = ic where = 616 value = 6 }
command = { type = metalpool value = 20 where = 616 }
command = { type = energypool value = 20 where = 616 }
command = { type = rarematerialspool value = 10 where = 616 }
command = { type = construct which = ic where = 606 value = 4 }
command = { type = metalpool value = 20 where = 606 }
command = { type = energypool value = 20 where = 606 }
command = { type = rarematerialspool value = 10 where = 606 }
command = { type = construct which = ic where = 608 value = 5 }
command = { type = metalpool value = 20 where = 608 }
command = { type = energypool value = 20 where = 608 }
command = { type = rarematerialspool value = 10 where = 608 }
command = { type = construct which = ic where = 780 value = 3 }
command = { type = metalpool value = 20 where = 780 }
command = { type = energypool value = 20 where = 780 }
command = { type = rarematerialspool value = 10 where = 780 }
command = { type = construct which = ic where = 603 value = 5 }
command = { type = metalpool value = 20 where = 603 }
command = { type = energypool value = 20 where = 603 }
command = { type = rarematerialspool value = 10 where = 603 }
command = { type = industrial_modifier which = total value = 25 }
}
}

 

[wilcoxchar]

They won't fire because you aren't at war with the Soviets. Since you only have one condition in your OR statement, the event considers that the only option for that statement and will thus only fire if the US is at war with the USSR.

 

[Micah Goodman 2]

Out of curosity should the Soviet portion of the trigger be AND, OR?

 

[Daelyn75]

Hmm, makes sense as it doesn't fire that the challenge is in the trigger. But logically I cannot understand this. Trigger means war with Japan/German, big slash / Or just at war with the Soviets as per my thinking. So war should be or with all then I take it.

 

[xtfoster]

Hmm, makes sense as it doesn't fire that the challenge is in the trigger. But logically I cannot understand this. Trigger means war with Japan/German, big slash / Or just at war with the Soviets as per my thinking. So war should be or with all then I take it.

The default condition is AND, so...
The trigger means
The USA must be at war with Germany
AND
The USA must be at war with Japan
AND
One of the following must be true
The USA must be at war with the USSR


Since there is only one condition in the OR, it has no effect.

EDIT:
If you wanted it to be at war with Germany AND Japan OR at war with the USSR you should have

trigger = {
	OR = {
		AND = {
			war = { country = USA country = GER }
			war = { country = USA country = JAP }
			}
		war = { country = USA country = SOV }
		}
}

EDIT2: Oops, forgot the OR

 

[Micah Goodman 2]

In a rleated question, if I want the trigger for this event to be that it fires if the Japanese ocupy all of the proviences listed in the first part of the trigger or if the Japanese occupy Guadalcanal, do I have the brackets done correctly...

############################################
### Americal Division Formed
### By Micah Goodman
############################################
event = {
id = 3182731
random = no
country = USA

trigger = {
OR = {
AND = {
war = { country = JAP country = USA }
control = { province = 1672 data = JAP } # Lae
control = { province = 1671 data = JAP } # Gasmata
control = { province = 1670 data = JAP } # Rabaul
control = { province = 1669 data = JAP } # New Ireland
}
AND = {
war = { country = JAP country = USA }
control = { province = 1685 data = JAP } # Guadalcanal
}
}

style = 0
picture = "american_reinforcments8"

date = { day = 10 month = may year = 1942 }

name = "The Americal Division"
desc = "As the US Army reorganized from four regiment divisions to three regiment divisions, several regiments became ‘orphaned’ or without a parent division. Many of these regiments were sent overseas individually. To slow the Japanese juggernaut in the Pacific several were sent to the South East Pacific. In May 1942 three of these regiments were formed into the ‘Americal’ Division. Under Major General Patch the division would soon be sent to Guadalcanal to assist the Marines."

action_a = {
name = "Form the Division"
ai_chance = 100
command = { type = activate_division which = 14800 value = 708 where = 1692 when = 0 } # Americal Division Activated
command = { type = manpowerpool value = -20 }
command = { type = supplies value = -1000 }
}

action_b = {
name = "Keep the Regiments Seperate"
command = { type = manpowerpool value = 20 }
command = { type = supplies value = 1000 }
}
}

 

[Daelyn75]

Yes it worked, thankyou very much! I was also able to get several others working as well that didn't work before because I misunderstood how OR works.

 

[xtfoster]

In a rleated question, if I want the trigger for this event to be that it fires if the Japanese ocupy all of the proviences listed in the first part of the trigger or if the Japanese occupy Guadalcanal, do I have the brackets done correctly...

	trigger = {
		OR = {
		   AND = {
			war = { country = JAP country = USA }
			control = { province = 1672 data = JAP } # Lae
			control = { province = 1671 data = JAP } # Gasmata
			control = { province = 1670 data = JAP } # Rabaul
			control = { province = 1669 data = JAP } # New Ireland
		}
		   AND = {
			war = { country = JAP country = USA }
			control = { province = 1685 data = JAP } # Guadalcanal
	}
}

You need one more bracket to close the OR statement...so

	trigger = {
		OR = {
		   AND = {
			war = { country = JAP country = USA }
			control = { province = 1672 data = JAP } # Lae
			control = { province = 1671 data = JAP } # Gasmata
			control = { province = 1670 data = JAP } # Rabaul
			control = { province = 1669 data = JAP } # New Ireland
		}
		   AND = {
			war = { country = JAP country = USA }
			control = { province = 1685 data = JAP } # Guadalcanal
                }
	}
}

also, since both include

war = { country = JAP country = USA }

you could move it before the OR statement and get away with only the one.

 

[Micah Goodman 2]

Great thanks.