Tester needed -- possible fix for siblings falling in love

jordarkelf · Jun 14, 2008

I'm sure most of us here have had the event "You have become infatuated to a girl in the same court" fire for a brother and sister before... ick.

I think I've finally figured out a fix for it, but I need some more people to test it.

Please change event 8201 in 'romance_events.txt' to the following:

Code:

character_event = { # You have become infatuated to a girl in the same court
	id = 8201

	picture = "event_romance"

	trigger = {
		condition = { type = gender value = male }
		condition = { type = age value = 12 }
		condition = { type = not value = { type = age value = 20 } }
		condition = { type = not value = { type = is_married } }
		condition = { type = not value = { type = ruler } }
		condition = { type = not value = { type = num_friends value = 3 } }
		condition = { type = not value = { type = trait value = celibate } }
		condition = { type = not value = { type = trait value = pneumonia } }
		condition = { type = not value = { type = trait value = blind } }
		condition = { type = not value = { type = trait value = leper } }
		condition = { type = not value = { type = trait value = plagueinfested } }
		condition = { type = not value = { type = trait value = depression } }
		condition = { type = not value = { type = trait value = schizofrenia } }
		condition = { type = not value = { type = trait value = maniac } }
		condition = { type = not value = { type = trait value = stress_symptom } }
		condition = { type = not value = { type = any_friend condition = { type = gender value = female } } }
		condition = { type = any_courtier
			condition = { type = gender value = female }
			condition = { type = age value = 12 }
			condition = { type = not value = { type = age value = 20 } }
			condition = { type = not value = { type = num_friends value = 3 } }
			condition = { type = not value = { type = is_friend } }
			condition = { type = not value = { type = is_rival } }
			condition = { type = not value = { type = is_married } }
			#condition = { type = not value = { type = is_sibling } } # Ick!
			condition = { type = not value = { type = trait value = celibate } }
			condition = { type = not value = { type = trait value = pneumonia } }
			condition = { type = not value = { type = trait value = blind } }
			condition = { type = not value = { type = trait value = leper } }
			condition = { type = not value = { type = trait value = plagueinfested } }
			condition = { type = not value = { type = trait value = depression } }
			condition = { type = not value = { type = trait value = schizofrenia } }
			condition = { type = not value = { type = trait value = maniac } }
			condition = { type = or
				condition = { type = not value = { type = num_friends value = 1 } }
				condition = { type = not value = { type = any_friend condition = { type = gender value = male } } }
			}
			condition = { type = save_target }
		}
		condition =  { type = not value = { type = father
			condition = { type = any_child
				condition = { type = and
					condition = { type = gender value = female }
					condition = { type = not value = { type = trait value = bastard } }
					condition = { type = is_alive }
					condition = { type = is_target }
				}
			}
		} }
		condition = { type = has_target }
	}

	mean_time_to_happen = {
		months = 100

		modifier = {
			condition = { type = trait value = romantic }
			factor = 0.8
		}
		modifier = {
			condition = { type = trait value = energetic }
			factor = 0.8
		}
		modifier = {
			condition = { type = trait value = reckless }
			factor = 0.8
		}
		modifier = {
			condition = { type = trait value = proud }
			factor = 0.8
		}
		modifier = {
			condition = { type = trait value = amiable }
			factor = 0.8
		}
		modifier = {
			condition = { type = trait value = gregarious }
			factor = 0.8
		}
		modifier = {
			condition = { type = trait value = lustful }
			factor = 0.8
		}
		modifier = {
			condition = { type = trait value = chaste }
			factor = 1.25
		}
		modifier = {
			condition = { type = trait value = shy }
			factor = 1.25
		}
		modifier = {
			condition = { type = trait value = hostile }
			factor = 1.25
		}
		modifier = {
			condition = { type = trait value = modest }
			factor = 1.25
		}
		modifier = {
			condition = { type = trait value = coward }
			factor = 1.25
		}
		modifier = {
			condition = { type = trait value = lazy }
			factor = 1.25
		}
		modifier = {
			condition = { type = trait value = pragmatic }
			factor = 1.25
		}
		modifier = {
			condition = { type = trait value = illness }
			factor = 1.25
		}
		modifier = {
			condition = { type = trait value = intestinal_worm }
			factor = 1.25
		}
	}

	action_a = { # I can feel the love overtake me!
		ai_chance = 50
		effect = { type = random chance = 75
			effect = { type = make_friend value = load_target }
		}
	}
	action_b = { # It will be fun for a while
		ai_chance = 25
		effect = { type = random chance = 25
			effect = { type = make_friend value = load_target }
		}
	}
	action_c = { # She's not that pretty really
		ai_chance = 25
		effect = { type = random chance = 20
			effect = { type = add_trait value = stress_symptom }
		}
	}
}

The new code is:

Code:

		condition =  { type = not value = { type = father
			condition = { type = any_child
				condition = { type = and
					condition = { type = gender value = female }
					condition = { type = not value = { type = trait value = bastard } }
					condition = { type = is_alive }
					condition = { type = is_target }
				}
			}
		} }

As can be seen, the new code just checks if the previously set target (female courtier in the same court) is not also a daughter of the same father, unless she's a bastard.
Paradox never uses the is_target code in its events but this actually seems to work!

Play a while with this version of the event and let me know if you still see it fire -- and if it does, if it works as wanted now. You should still see non-brothers and sisters fall in love, but no more incestuous relations occur.

jordarkelf · Jun 23, 2008

So... has anyone tried this yet? Does it work reliably now?
60+ views but no comments

IamWhoa · Jun 24, 2008

I've installed it but I haven't gotten around to playing lately. I'll try it tonight, just for you

Edit: I've kept from sending out fosterlings and there have been no incestuous relationships yet. I haven't really had any unrelated children in the court to see if this works, though. I'll check back later.

Davisx3m · Jun 26, 2008

If u make it into a file so i can dl it then i can test it ( I know im lazy)

jordarkelf · Jun 26, 2008

@IamWhoa: thanks, that confirms what I've seen so far. I think it works right, as when I test-fire it it works as expected. Triggers do not match for siblings, but do for strangers. I just haven't had the event fire by itself yet

@Davisx3m: You must overwrite the event in romance_events.txt with this version. Providing a file would mean I'd have to upload the entire file here, and you already have it.
I think it works, so it'll go in the next DVIP. If you don't want to change it yourself, be patient

ambrox62 · Jun 26, 2008

An alternate way to fix such event could be the following:

condition = { type = not value = { type = father condition = { type = any_child condition = { type = is_receiver } } } }

Put this line inside any_courtier loop just before save_target check:

condition = { type = any_courtier
.....
condition = { type = not value = { type = father condition = { type = any_child condition = { type = is_receiver } } } }
condition = { type = save_target }
}

This way you check brotherhood directly into the loop, searching for further suitable girls instead of exit the loop and then abort the selected char

It needs a test.

jordarkelf · Jun 26, 2008

Interesting idea. Will test this.

Ashtray · Jul 27, 2008

jordarkelf said:
Interesting idea. Will test this.

Any progress with this?

jordarkelf · Jul 27, 2008

No, because nobody replies with their results

Pretty sure it's working so I've included these fixes in the DVIP.

Ashtray · Jul 30, 2008

jordarkelf said:
No, because nobody replies with their results

Pretty sure it's working so I've included these fixes in the DVIP.

As soon as my Golfer's elbow is cured I will test it.

IamWhoa · Aug 8, 2008

I can finally confirm that this works between non-relatives. It just doesn't seem happen very often.

jordarkelf · Aug 8, 2008

Thanks IAW, that's all the confirmation I needed.

I've modified the version I actually use with ambrox62' suggestion, which potentially makes it fire more often for valid (non-relative) targets, so hopefully you will be able to see it in DVIP games -- but not for siblings

Search

Tester needed -- possible fix for siblings falling in love

jordarkelf

01_TITLE_STRING

jordarkelf

01_TITLE_STRING

IamWhoa

Captain

Davisx3m

Long live love!

jordarkelf

01_TITLE_STRING

ambrox62

Very hard level player

jordarkelf

01_TITLE_STRING

Ashtray

Second Lieutenant

jordarkelf

01_TITLE_STRING

Ashtray

Second Lieutenant

IamWhoa

Captain

jordarkelf

01_TITLE_STRING