Sorry, but unless you've seen the source for how Johan has implemented the ToT, HRE and straits, the plain fact of the matter is that you are guessing.Jinnai said:Actually yes i do have some idea atleast.
Right, all of that above is a guess. I can also speculate about Johan's method for implementing this in another way which is easily moddable.Jinnai said:Making anything moddable isn't simple, epseically when doing so to an existing engine. The fact he can load CSV files in only 1 thing. He also has it coded to look specifically at certain parts of the coded files, the way the event that creates the ToT conditions fire special hardcoded tags, the way he'd haveto turn off many functions already in existance, then make a way in the code to change the way csv file for province.csv is read, then actually impliment the changes to province.csv for the next patch for each and every province in vanilla. Your not talking here about simply adding some new code to the exe here.
For instance, what if the ToT list is an array of pairs which are initialised as follows:
Code:
typedef struct { int prov_id; int nation; } TOTEntry;
TOTEntry TOTlist[99] =
{ 179, TOT_SPAIN },
{ 180, TOT_SPAIN },
{ 181, TOT_SPAIN },
...
{ 202, TOT_PORTUGAL },
{ 203, TOT_PORTUGAL },
{ 204, TOT_PORTUGAL },
...
But as I said: I'm guessing, you're guessing.
So -6 functionality already exists for some commands? So logically we can guess that it must be added separately to each command, depending on context. Therefore, it would take longer than adding a call to load a csv.Jinnai said:As to the -6 functionality, the fact is something like it already exists for commands. while its not as simple as making a new command, its hardly comprable to making ToT provinces moddable.
Again: I'm guessing, you're guessing.
No, you're guessing. According to your post above, somebody has told you Johan won't spend much time if any on new functionality. Your reaction seems to be that you have decided - without seeing any source code nor asking Johan himself - what will take time and what is easy. However, neither you nor I know what Johan can do easily. Therefore I would agree that keeping the wishlist small is a good tactic, but I suggest that you leave the implementation up to Johan.Jinnai said:Because I already know the answer.
The reason I argue this is from professional experience. I often have clients who try to tell me the solutions to the problems in their software. Often they don't even explain the problem, just demand the solution. Whereas, if they had explained the problem, I could present several solutions and explain the benefits and costs of each of them.
So if were Johan (and clearly I'm not), I would prefer to read in the wishlist: "In order to take full advantage of the extra 400 province ids, we need the list of TOT, HRE and straits provinces to be expanded. Ideally these would be editable in CSV files, but some extra province ids added to the hardcoded list would also be acceptable." This way, he understands the motivation for the request.