Patch 2.3 Compatibility for Mods

[Blood Royal]

To get a rather extensive total conversion mod working with 2.3 seems easy enough.

Update defines.lua, and update whatever /interface files you have changed (using winmerge on your mod /interface and comparing it to the vanilla /interface folder works best for this).

BUT -

I got like 20 blank event pop ups after 2 weeks or so of game time.

Has any other modders gotten these, and if so, does anyone know why?

Lots of my events don't use localisation, but I don't thiiink that' the problem anymore... I only get around 20 blank event pop ups, and if it were my events, I'd be getting like 200 of em...

 

[Meneth]

An issue I've encountered:

If k_germany and/or k_byzantium don't exist, the game won't launch. Probably caused by something referencing those titles, so won't affect all mods.
Simply adding dummy titles with those names fixes the crash, so if anyone is having a crash on launch it may be worth looking into.

 

[omega20056]

The only thing I can find that this patch broke is custom event localisations. Using name = "whatever" now results in a blank button.

 

[fanoI]

I hope this thing to release DLC after only two weeks from another does not become the norm! I was at least finished the porting of my mod to CM and now WOL destroys all again?
Unbelievable... now we have hardcoded titles too!

 

[Blood Royal]

The only thing I can find that this patch broke is custom event localisations. Using name = "whatever" now results in a blank button.

Damn, that's what I was afraid of. So that counts for desc = "This is the description" too?

That's... absolutely horrid, considering I've made like close to 1000 events that now suddenly need to be localised.

I hope this thing to release DLC after only two weeks from another does not become the norm! I was at least finished the porting of my mod to CM and now WOL destroys all again?
Unbelievable... now we have hardcoded titles too!

If it wasn't for the event localisation issue, the patch process for 2.3 is easy. Just defines.lua and update the changed /interface files to include the new lines.

 

[apg]

To get a rather extensive total conversion mod working with 2.3 seems easy enough.

Update defines.lua, and update whatever /interface files you have changed (using winmerge on your mod /interface and comparing it to the vanilla /interface folder works best for this).

BUT -

I got like 20 blank event pop ups after 2 weeks or so of game time.

Has any other modders gotten these, and if so, does anyone know why?

Lots of my events don't use localisation, but I don't thiiink that' the problem anymore... I only get around 20 blank event pop ups, and if it were my events, I'd be getting like 200 of em...

Indeed these blank events are a problem Richvh told me that every limit now has to be after an if, any_* or random_* but these do not stop blank events from firing - also regarding the blank text boxes I really hope the devs fix this... As I dont see the point in all of a sudden not allowing customised localisation directly in the text file when it worked well for so long, hopefully this is an oversight.

 

[Blood Royal]

Indeed these blank events are a problem Richvh told me that every limit now has to be after an if, any_* or random_* but these do not stop blank events from firing - also regarding the blank text boxes I really hope the devs fix this... As I dont see the point in all of a sudden not allowing customised localisation directly in the text file when it worked well for so long, hopefully this is an oversight.

Thanks for hte extra info! And yeah, I'm not even seriously contemplating re-doing hundreds of hours of event work I've done without localisation... I really hope they can fix this or come up with something in the next patch, or else the Birthright mod and Warhammer mod (and possibly the Middle Earth mod if they haven't yet localised all my events) are gonna be on hold indefinitely or set back to mostly pre-custom-event status with this patch compatibility issue.

 

[richvh]

No inline text for events didn't affect LI at all, since I'm obsessive about fixing any Validator error reported if at all possible, and had already moved all of that into localization.

Besides limits being used in the wrong place, any other invalid scope will cause a blank event. Validator is your friend...

 

[Blood Royal]

No inline text for events didn't affect LI at all, since I'm obsessive about fixing any Validator error reported if at all possible, and had already moved all of that into localization.

Besides limits being used in the wrong place, any other invalid scope will cause a blank event. Validator is your friend...

Fair enough Richvh, but I developed an irrational hatred of localisation in my early modding days back when I used Excel for it (rather than notepad++ which I later discovered works just as well).

It doesn't seem fair to change the rules of modding mid-game like this, after several scripters developed a taste for writing the event descriptions/options directly into the file so they can instantly spot what the event does and make quick changes to the description/options as needed.

I even posted a bug report about this 2-3 weeks ago in the bug reporting forum, but it seems to have been ignored.

Normally I don't mind doing patch adaptations as this is obviously required to get the new content into the mod, but this one - this seems like someone made a mistake, and didn't take into account all the mods that don't use event localisation and I really do hope they'll fix this in the next patch.

 

[omega20056]

Damn, that's what I was afraid of. So that counts for desc = "This is the description" too?

That's... absolutely horrid, considering I've made like close to 1000 events that now suddenly need to be localised.



If it wasn't for the event localisation issue, the patch process for 2.3 is easy. Just defines.lua and update the changed /interface files to include the new lines.

I localise my descriptions in the localisation files, but I assume it would cause them to be blank too.

 

[Rylock]

I localise my descriptions in the localisation files, but I assume it would cause them to be blank too.

Unless I'm mistaken, no -- the issue for them is that now the descriptions HAVE to be localized via the files, whereas before you could just put the text in quotes if you didn't want to worry about it (and didn't intend to translate anything).

 

[theStormWeaver]

As a programmer, using raw strings (instead of using localization) is abhorrent, and I think they never should have allowed it in the first place.

But they probably shouldn't just drop support for it.

 

[apg]

Besides limits being used in the wrong place, any other invalid scope will cause a blank event. Validator is your friend...

I am confused how this would occur though as before this patch (and the betas) I had no blank firing events, now after the update I am bombarded with them lol

So surely there must have been a conscious change by the devs somewhere along the line.

 

[JonStryker]

As a programmer, using raw strings (instead of using localization) is abhorrent, and I think they never should have allowed it in the first place.

But they probably shouldn't just drop support for it.

As a programmer I learned to love to use strings inplace. If you never intend to make a translated version what purpose do localisations serve then?

 

[Jams]

As a programmer I learned to love to use strings inplace. If you never intend to make a translated version what purpose do localisations serve then?

It's never good to learn bad habits then complain when they don't work properly. I've been burned by this habit twice before.

 

[Jorlem]

Have the factors for ai_chance been changed? I don't recall seeing values of 1000 before...

 

[chatnoir17]

An issue I've encountered:

If k_germany and/or k_byzantium don't exist, the game won't launch. Probably caused by something referencing those titles, so won't affect all mods.
Simply adding dummy titles with those names fixes the crash, so if anyone is having a crash on launch it may be worth looking into.

You are right, the game runs if these titles aren't used on the map and other area in overhaul mods such as NMIH.

 

[theStormWeaver]

As a programmer I learned to love to use strings inplace. If you never intend to make a translated version what purpose do localisations serve then?

Because its equivalent to Magic Numbers. And if you need to use it in more places than once, you have to track down every single instance and update it, even if you don't remember where they all are.

Its just bad practice.

 

[theStormWeaver]

Have the factors for ai_chance been changed? I don't recall seeing values of 1000 before...

I thought ai_chance worked like other probability based fields, the chance values are proportional. They are all chance/sum_of_all_chances.

 

[Arko]

An issue I've encountered:

If k_germany and/or k_byzantium don't exist, the game won't launch. Probably caused by something referencing those titles, so won't affect all mods.
Simply adding dummy titles with those names fixes the crash, so if anyone is having a crash on launch it may be worth looking into.

because they are used in events ?
if it is the cause, other titles like papacy, holy orders and others might cause issues aswell.