I think the 'not safe' camp has forgotten a couple of extremely important points.
Firstly, hashing is secure enough
for this purpose - especially if they are (as all people should) be adding a salt to the hash (which can also be stored in the save file) to prevent a straight up hash-only rainbow table from working. When it comes to cracking the hash they need to bear in mind that 99.5% of players either:
- Lack the technical skills to do it; or
- Cant be bothered to do it (as people have already pointed out - it would require a lot of time to brute force the hash); or
- Wont do it because it's a stink thing to do
Secondly, if you want to bypass the security all together then you're getting into cracking the EXE. This would take a significant amount of time and is something that only an
extremely small number of people would have the technical skills to do as you are now having to bypass all of PDS's security features (as they check if any of the game files are modified/tampered with) and not just a single hashed password. I'm willing to bet that of the people that are able to do this roughly 0 of them will ever be bothered to put in that much time just so they can play someone else's country in a MP game.
It is a very good suggestion that players should be strongly advised when picking a password not to use any of their existing ones (maybe tell them that these passwords are ok to write down). I don't agree that the risk of 'criminal elements' is large enough to make a hashed password a bad idea. Other than them have to spend a large amount of time and computing power just to grab a few save game passwords (when there are still thousands of websites with terrible security and huge user databases) it's not a good argument that we should not use passwords because there are some bad people out there trying to crack passwords. It's still a lot better than having no password at all.
There is no reason this couldn't work and the argument that hashing would be an inadequate security measure for this feature is not a strong one.