@Anyasia you absolute legend ! I went with your
customizable_localization idea, using a self-made
scripted_trigger, and it works like a charm !
It might seem small, but it's so satisfying to fix !
My issue was simple in the regard that in french only pagan
HouseOfWorship are "male", regarding your issues I think I would make a
customizable_localization for each religion depending on its religious texts being singular or plural, and for head of faith it seems more complicated as some faith can have both male and female Head I suppose ? (I don't know much about faith that aren't Asatru so far, I haven't played the game that much)
Figured I'd follow up on this to say that this fix worked an absolute charm. I won't bore you with the nitty gritty unless you find a particular need or interest, but one little bug came up that might affect your code as well, so I wanted to pass it along together with my remedy. Specifically, if you have any
faith-based triggers (as opposed to those based on
religion), they will fail to account for reformed pagan faiths or player-created faiths.
To use one example, Bogomilist priests are called 'elect' in English, and thus require the indefinite article 'an' rather than 'a.' Since other Christian priests are, well, 'priests,' this requires a faith-specific check to apply
specifically to Bogomils. But if a player schisms his custom faith from Bogomilism, it will inherit the 'elect' name for its priests, but will no longer match triggers checking for
faith:bogomilism, resulting in the reïntroduction of the erroneous localization
'a elect.'
In your use case, if a specific faith is flagged to conjugate with a particular gender, and the player reforms or schisms from that faith, his newly-created faith will reset to the default conjugation instead.
The fix for this is twofold. First, I set a variable on all created faiths to keep track of the vanilla faith from which they ultimately inherit their localizations. This is, incidentally, done in vanilla, but—due to what I assume is an oversight rather than a deliberate decision—the vanilla variable is set on the faith's
founder, rather than on the faith itself, and unfortunately, character variables are cleared on death, making it useless beyond the lifespan of the founder.
Code:
# common/on_action/anyasia.txt
on_faith_created = {
on_actions = {
anyasia_log_foundational_faith
}
}
anyasia_log_foundational_faith = {
effect = {
faith = {
if = {
# If the old faith was itself player-created/reformed, use its existing foundational faith…
limit = { scope:old_faith = { has_variable = foundational_faith } }
set_variable = {
name = foundational_faith
value = scope:old_faith.var:foundational_faith
}
}
else = {
# …otherwise, set the old faith as the foundational faith
set_variable = {
name = foundational_faith
value = scope:old_faith
}
}
}
}
}
I then check for the existence of this variable in my custom localization, saving it as a temporary scope if it exists, and saving the
actual faith as the
same temporary scope if it doesn't. Then it's just a matter of using that temporary scope for your trigger checks, rather than
faith:—
Code:
# common/customizable_localization/anyasia.txt
GetPriestArticle = {
type = character
text = {
trigger = {
trigger_if = {
# If the character's faith has a foundational faith defined, save it as a temporary scope…
limit = { exists = faith.var:foundational_faith }
faith.var:foundational_faith = { save_temporary_scope_as = the_faith }
}
trigger_else = {
# …otherwise, save the character's faith itself
faith = { save_temporary_scope_as = the_faith }
}
# Use the saved temporary scope:the_faith in the actual trigger checks
OR = {
AND = {
is_male = yes
scope:the_faith.religion = religion:west_african_bori_religion # adjingi
}
AND = {
is_female = yes
scope:the_faith = faith:digambara # aryika
}
scope:the_faith = faith:bogomilist # elect
scope:the_faith.religion = religion:tani_religion # abu
scope:the_faith = { has_doctrine = muhammad_succession_sunni_doctrine } # imam
scope:the_faith = faith:quranist # imam
scope:the_faith = faith:melieism # unia
}
}
localization_key = article_an
}
text = {
localization_key = article_a
fallback = yes
}
}
I know you said your own custom localization affected pagans generally, so you might not have any of these faith-specific checks with which to contend, but if you do, hopefully this gives you a lead on how to deal with them! Thank you again for your input on this matter and for pointing me in the right direction; I'm glad I was finally able to deal with some of those pesky edge cases that the devs seem to've missed.
