[MOD] EMF: Extended Mechanics & Flavor

[ahistorically correct]

Just tried a quick test merging just the relevant portions of commits from github (three files, EMF_decisions.gfx, emf_prison_decisions.txt and emf_prisoner.txt) into latest EMF while keeping the later EMF changes of the files. Superficially, it seems to work - I finally see the Ransom All decision and it seems to somewhat work, great! Of course, I have no idea if it breaks anything or how well it works with current version, since the code I copied is from 2017...

Would be great if the devs could chime in, thanks!

 

[ahistorically correct]

What's the deal with Zoroastrian and Yazidi Great Holy Wars? How to Unlock Crusades or Great Holy Wars for Zoroastrian or Yazidi faiths?

Tried to call Great Holy War as Yazidi sheikh. The Send button is greyed out and the pop-up only says:

(X) The Ahura Mazda Great Holy War Era has Began

(all the other requirements are met)

It's year 1295, I hold all the Yazidi holy sites and I am Sheikh with Yazidi having 78% moral authority (I converted all of realm for sake of testing).
Global flags emf_crusades_unlocked, muslim_jihads_unlocked, christian_crusades_unlocked are all SET (I checked).

So, what's the requirement to unlock it? The CK2 Wiki says Zoroastrian faith unlocks GHW immediately upon creating Moabadan-Moabad. In another play through, I did just that and never got any option for GHW at all, not even greyed out, just regular holy wars. EMF wiki doesn't mention unlocking crusades at all.

Finally, I delved for a few hours into the EMF code:

00_cb_types.txt checks for zoroastrian_ghws_unlocked global flag to allow GHWs for these religions. Great. Setting the flag manually via console works. But what's the normal requirement?

The only place that ever sets the zoroastrian_ghws_unlocked global flag is emf_religion.txt (plus alternate - random world - starts):

Spoiler: # emf_religion.4 -- Activation of Mazdan Great Holy Wars, after two of Christians, Muslims, and Pagans

# emf_religion.4 -- Activation of Mazdan Great Holy Wars, after two of Christians, Muslims, and Pagans
narrative_event = {
    id = emf_religion.4
    title = EVTNAME_emf_religion_4
    desc = {
        trigger = {
            has_global_flag = muslim_jihads_unlocked
            has_global_flag = christian_crusades_unlocked
        }
        text = EVTDESCA_emf_religion_4
    }
    desc = {
        trigger = {
            has_global_flag = pagan_ghws_unlocked
            has_global_flag = christian_crusades_unlocked
        }
        text = EVTDESCB_emf_religion_4
    }
    desc = {
        trigger = {
            has_global_flag = muslim_jihads_unlocked
            has_global_flag = pagan_ghws_unlocked
        }
        text = EVTDESCC_emf_religion_4
    }
    picture = GFX_evt_zoroaster
    border = GFX_event_narrative_frame_religion

    major = yes

    show_ROOT = yes
    hide_new = yes

    only_playable = yes
    min_age = 16
    religion_group = zoroastrian_group

    trigger = {
        controls_religion = yes
        is_heretic = no
        can_call_crusade = yes
        NOT = { has_alternate_start_parameter = { key = religion_names value = random } }
        NOT = { has_global_flag = zoroastrian_ghws_unlocked }
        calc_true_if = {
            amount = 2
            has_global_flag = muslim_jihads_unlocked
            has_global_flag = christian_crusades_unlocked
            has_global_flag = pagan_ghws_unlocked
        }
    }

    mean_time_to_happen = {
        months = 120
        modifier = {
            factor = 0
            has_global_flag = emf_debug_fast_ghw_unlock
        }
        modifier = {
            factor = 0.5
            any_landed_title = {
                is_holy_site = ROOT
                owner = {
                    top_liege = {
                        NOR = {
                            religion_group = ROOT
                            ROOT = { emf_syncretized_religion_with_PREV = yes }
                        }
                        trigger_if = {
                            limit = { religion_group = christian }
                            has_global_flag = christian_crusades_unlocked
                        }
                        trigger_else_if = {
                            limit = { religion_group = muslim }
                            has_global_flag = muslim_jihads_unlocked
                        }
                        trigger_else_if = {
                            limit = { religion_group = pagan_group }
                            has_global_flag = pagan_ghws_unlocked
                        }
                        trigger_else_if = {
                            limit = { religion_group = jewish_group }
                            has_global_flag = jewish_ghws_unlocked
                        }
                    }
                }
            }
        }
        modifier = {
            factor = 2
            NAND = {
                ROOT = { religion_scope = { has_religion_feature = religion_syncretic_christian } }
                has_global_flag = christian_crusades_unlocked
            }
            NAND = {
                ROOT = { religion_scope = { has_religion_feature = religion_syncretic_muslim } }
                has_global_flag = muslim_jihads_unlocked
            }
            NOT = {
                any_landed_title = {
                    is_holy_site = ROOT
                    NOT = {
                        owner = {
                            top_liege = {
                                OR = {
                                    religion_group = zoroastrian_group
                                    ROOT = { emf_syncretized_religion_with_PREV = yes }
                                    liege_before_war = {
                                        OR = {
                                            religion_group = zoroastrian_group
                                            ROOT = { emf_syncretized_religion_with_PREV = yes }
                                        }
                                    }
                                }
                            }
                        }
                    }
                }
            }
        }
    }

    immediate = {
        set_global_flag = zoroastrian_ghws_unlocked
    }

    option = {
        name = EVTOPTA_emf_religion_4
        trigger = {
            religion_group = zoroastrian_group
        }
    }

    option = {
        name = EVTOPTB_emf_religion_4
        trigger = {
            NOT = { religion_group = zoroastrian_group }
        }
    }
}

So the from above code, it seems that MTTH for Zoroastrians unlocking GHWs is 10 years (with possible 0.5x or 2x modifiers depending on conditions)?
I couldn't be bothered waiting 10 years just testing it, so I used the emf_debug flag, Zoro GHW Unlocked event fired almost immediately - so it works. Unfortunately, there is no mention of it anywhere and it took me several hours finding the answer in the code...