The Militarist ethic states that it will grant +10% happiness to all pops when at war. I have observed across three games (and three different civs) that this is not the case. Whether offensive or defensive war, my pops are receiving no happiness bonus during wartime. They're not getting the usual penalty, hence why I'm still using it, but the trait tooltip promises a happiness bonus which does not materialize.