Large bug with leader portraits and filenames

[Rhedd]

I have the Impulse version of the game, and am playing in English (if that matters), and I've found a bug with the filenames of leaders whose names include foreign characters.

I first noticed that in the 1941 scenario, Göring didn't have a portrait.

Looking in db/leaders/german.csv I found that the game was looking for a portrait named "Göring_hermann_ger"(.bmp), but in the gfx/interface/pics folder, the name of the proper portrait was "Göring_hermann_ger.bmp. The "ö" gets replaced by junk!

This is true of every single filename that includes non-English characters. The other filenames near Göring's portrait are...
Göbel_karl_ger.bmp
Göldner_paul_ger.bmp
Götting_friedrich_ger.bmp
Güntzel_ernst_ger.bmp
etc.

There are plenty of others, such as
Böhlke_hellmuth_ger.bmp and Crüwell_ludwig_ger.bmp

I changed Göring's filename to Göring_hermann_ger.bmp and it now works fine, so that is the problem.

Unfortunately, I have no idea what everyone's name should be, so I can't go through and change them all myself!

I didn't think anything had changed with leaders in AoD. Makes me wonder why they were changed from just being numbers, like in HoI2. Must've been a lot of work!

 

[Lennartos]

I have the Impulse version of the game, and am playing in English (if that matters), and I've found a bug with the filenames of leaders whose names include foreign characters.

I first noticed that in the 1941 scenario, Göring didn't have a portrait.

Looking in db/leaders/german.csv I found that the game was looking for a portrait named "Göring_hermann_ger"(.bmp), but in the gfx/interface/pics folder, the name of the proper portrait was "Göring_hermann_ger.bmp. The "ö" gets replaced by junk!

This is true of every single filename that includes non-English characters. The other filenames near Göring's portrait are...
Göbel_karl_ger.bmp
Göldner_paul_ger.bmp
Götting_friedrich_ger.bmp
Güntzel_ernst_ger.bmp
etc.

There are plenty of others, such as
Böhlke_hellmuth_ger.bmp and Crüwell_ludwig_ger.bmp

I changed Göring's filename to Göring_hermann_ger.bmp and it now works fine, so that is the problem.

Unfortunately, I have no idea what everyone's name should be, so I can't go through and change them all myself!

I didn't think anything had changed with leaders in AoD. Makes me wonder why they were changed from just being numbers, like in HoI2. Must've been a lot of work!

i have written a mail to johan about this.
it seems that:
ö = ö
ü = ü/ä
There are around 190 images using these characters for techteams and new images.
I will try to make a hotfix ASAP.

 

[Rhedd]

Thank you!

There are other combinations of junk characters, too, of course. I spotted these in the filenames, too:
Ã¥
ß
ä
é

There are probably more.

Searching /pics for "Ã", I found 212 files. Assuming all of the messed up ones start include Ã, that should be all of them.

 

[Lennartos]

im working on it - very tedius work

 

[Lennartos]

mhhhh
one moment

 

[Rhedd]

I bet it is tedious!

 

[Lennartos]

http://www.bl-logic.dk/Games/AOD/HotFix/gfx_Fix.rar

just had the idea: why not just replace the broken images

 

[Cardus]

i have written a mail to johan about this.
it seems that:
ö = ö
ü = ü/ä
There are around 190 images using these characters for techteams and new images.
I will try to make a hotfix ASAP.

Regarding TTs the picture's name the issue should be already fixed. Please have a look at the current pack.

 

[Rhedd]

Thanks for the speedy fix, Lennartos! I notice, however that your fixed /pics includes 201 files, but my search for files with an "Ã" in them turns up 212, so I think 11 of them might still be broken. I hope you didn'd do this all for nothing, since Cardus said it was already fixed.

Cardus, this "current pack" you mentioned, where can I get that, or are you referring to an internal build?

 

[Cardus]

Thanks for the speedy fix, Lennartos! I notice, however that your fixed /pics includes 201 files, but my search for files with an "Ã" in them turns up 212, so I think 11 of them might still be broken. I hope you didn'd do this all for nothing, since Cardus said it was already fixed.

Cardus, this "current pack" you mentioned, where can I get that, or are you referring to an internal build?

Please follow my signature for the TTs ver 1.3 BETA. If you spot any issue please report it in the same thread.

 

[Rhedd]

Ah, thank you, Cardus! I can't tell who is a developer and who isn't, on AoD. They need a fancy nametag! ^_^

 

[Gazer75]

The sad result of poor QA at retailers and/or not using Unicode character sets in their software...

 

[Czarina Julie]

Lennartos, Not sure if this help but this is how I handle it in the Archiver. I had to stipulate the encoding.

//load & read the file
string fName = lblSelectedFile.Text;
StreamReader testTxt = new StreamReader(fName,System.Text.Encoding.ASCII);
string allRead = testTxt.ReadToEnd();
testTxt.Close();
StreamWriter SW;