I've figured it out! v1.3a GPW bug...

blue emu · Jan 29, 2006

I know that I'm a little late with this, and that user-made GPW fixes are already out... but I thought I would share this with you to straighten the matter out:

Everyone knows that the v1.3b introduced a new bug into the Soviet GPW event series... but from there on, opinions differ widely...

Some claim that the v1.3a GPW events are correct, and all you have to do is substitute them for the v1.3b events, and that fixes the problem.

Others claim that the v1.3a events don't work either... that the "under_attack" command must be buggy, or that the early GPW events "sleep" the wrong sets of subsequent events...

In fact... the "under_attack" command is fine, and the v1.3a GPW events do "sleep" the correct events... the PROBLEM is that several of the v1.3a GPW events have the wrong start and end dates... the natural rises are all fine, but the "under_attack" GPW jumps are all dated one year too late (both start and end), so that they do not become valid until they have already been "slept" by the next natural rise event.

Example: event 2657 is supposed to apply from May 1940 to the end of April 1941... but it is wrongly dated to start in May 1941 (by which time it has already been slept by event 2652!) and run until end of April 1942.

The bug can be fixed by "rolling back" the start and end dates of the "under_attack" jumps by exactly one year... except for the first one, which rolls back to the Dec 12th 1939 natural rise.

unmerged(42079) · Jan 29, 2006

Nice find! That should put all the misunderstanding aside.

Camrik · Jan 29, 2006

4fresh said:
Nice find! That should put all the misunderstanding aside.

Indeed. Hope Paradox makes a 1.3c fix soon.

Ghis

101Man · Jan 30, 2006

Camrik said:
Indeed. Hope Paradox makes a 1.3c fix soon.

IIRC, Lothos stated in an earlier 1.3b thread that Paradox will not upgrade anything until the release of Doomsday.

unmerged(51416) · Jan 30, 2006

101Man said:
IIRC, Lothos stated in an earlier 1.3b thread that Paradox will not upgrade anything until the release of Doomsday.

Can anyone do it? And place it on the main page so Lothos hopefuly stick it - and we'll have our 1.3c

Also, have you checked this thread? http://forum.paradoxplaza.com/forum/showthread.php?t=229135

unmerged(22452) · Jan 30, 2006

This seems like such an easy fix I wonder why it isn't handled as a hot-fix rather than a full patch. I have to imagine it wouldn't take more than 4-5 hours from a coder at most.

unmerged(51416) · Jan 30, 2006

blue emu, could you post it somewhere here? The whole GDE bug thing is unclear to me so I'l rather rely on someone else who know how to do it right..

Also, do you use SMEP? And is it compatible?

blue emu · Jan 30, 2006

I don't use any Mods... so I don't know if it's compatible.

Assuming that you have v1.3b installed (although this SHOULD work with v1.3a too... haven't tested it):

Go into your:

>My Computer / Local Disk / Program Files / Paradox Interactive / Hearts of Iron 2 / db / events folder, and open (in Notepad) the ussr.txt file. You might want to paste a safe-copy of it onto your Desk-Top first, in case you mess something up.

Copy-and-Paste the following code over the ENTIRE Great Patriotic War section, near the end of your ussr.txt file... it REPLACES the existing code:

#########################################
#
# USSR GPW AI/human event chain - 1.2
#
# NEW EVENTS!
#
#########################################

event = {
id = 2660
random = no
country = SOV

trigger = {
ai = no
}

date = { day = 12 month = december year = 1939 }

name = "USSR_GEAR_1"
desc = "USSR_GEAR_2"
style = 0
picture = "soviet_strategic_victory"

action_a = {
name = "OK"
command = { type = ground_def_eff value = 0.10 } # 0.1 rise
command = { type = sleepevent which = 2655 } # first jump event
}
}

event = {
id = 2651
random = no
country = SOV

trigger = {
ai = no
}

date = { day = 1 month = may year = 1940 }

name = "USSR_GEAR_1"
desc = "USSR_GEAR_2"
style = 0
picture = "soviet_strategic_victory"

action_a = {
name = "OK"
command = { type = ground_def_eff value = 0.10 } # 0.1 rise
command = { type = sleepevent which = 2655 } # 1. and 2. jump event
command = { type = sleepevent which = 2656 }
}
}

event = {
id = 2652
random = no
country = SOV
style = 0

picture = "soviet_strategic_victory"

trigger = {
ai = no
}

date = { day = 1 month = may year = 1941 }

name = "USSR_GEAR_1"
desc = "USSR_GEAR_2"
action_a = {
name = "OK"
command = { type = ground_def_eff value = 0.10 } # 0.1 rise
command = { type = sleepevent which = 2655 } # 1., 2., 3. jump event
command = { type = sleepevent which = 2656 }
command = { type = sleepevent which = 2657 }
}
}

event = {
id = 2653
random = no
country = SOV
style = 0

picture = "soviet_strategic_victory"

trigger = {
ai = no
}

date = { day = 1 month = may year = 1942 }

name = "USSR_GEAR_1"
desc = "USSR_GEAR_2"
action_a = {
name = "OK"
command = { type = ground_def_eff value = 0.10 } # 0.1 rise
command = { type = sleepevent which = 2655 } # 1., 2., 3., 4. jump event
command = { type = sleepevent which = 2656 }
command = { type = sleepevent which = 2657 }
command = { type = sleepevent which = 2658 }
}
}

event = {
id = 2654
random = no
country = SOV
style = 0

picture = "soviet_strategic_victory"

trigger = {
ai = no
}

date = { day = 1 month = may year = 1943 }

name = "USSR_GEAR_1"
desc = "USSR_GEAR_2"
action_a = {
name = "OK"
command = { type = ground_def_eff value = 0.10 } # 0.1 rise
command = { type = sleepevent which = 2655 } # 1., 2., 3., 4., 5. jump event
command = { type = sleepevent which = 2656 }
command = { type = sleepevent which = 2657 }
command = { type = sleepevent which = 2658 }
command = { type = sleepevent which = 2659 }
}
}

event = {
id = 2666 # extra GDE rise event that occurs to make the russian forces equal to others
random = no
country = SOV
style = 0

picture = "soviet_strategic_victory"

trigger = {
ai = no
}

date = { day = 1 month = may year = 1944 }

name = "USSR_GEAR_1"
desc = "USSR_GEAR_2"
action_a = {
name = "OK"
command = { type = ground_def_eff value = 0.10 } # 0.1 rise
command = { type = sleepevent which = 2655 } # 1., 2., 3., 4., 5. jump event
command = { type = sleepevent which = 2656 }
command = { type = sleepevent which = 2657 }
command = { type = sleepevent which = 2658 }
command = { type = sleepevent which = 2659 }
}
}

event = { # first gde jump event
id = 2655
random = no
country = SOV

trigger = {
ai = no # human only
under_attack = SOV # any attack on USSR
NOT = { event = 2656 }
NOT = { event = 2657 }
NOT = { event = 2658 }
NOT = { event = 2659 }
random = 10
}

name = "fbarb_event8_name"
desc = "fbarb_event8_desc"

picture = "great_patriotic_war"
style = 0

date = { day = 1 month = january year = 1936 }
offset = 10 # Check for trigger conditions every 10 days
deathdate = { day = 12 month = december year = 1939 }

action_a = {
name = "OK"
command = { type = ground_def_eff value = 0.50 } # Rise to 0.7
command = { type = sleepevent which = 2660 } # Sleep natural rise
command = { type = sleepevent which = 2651 } # Sleep natural rise
command = { type = sleepevent which = 2652 } # Sleep natural rise
command = { type = sleepevent which = 2653 } # Sleep natural rise
command = { type = sleepevent which = 2654 } # Sleep natural rise
command = { type = sleepevent which = 2656 } # Sleep other GPW
command = { type = sleepevent which = 2657 } # Sleep other GPW
command = { type = sleepevent which = 2658 } # Sleep other GPW
command = { type = sleepevent which = 2659 } # Sleep other GPW

}
}

event = {
id = 2656
random = no
country = SOV

trigger = {
ai = no # human only
under_attack = SOV # any attack on USSR
NOT = { event = 2655 }
NOT = { event = 2657 }
NOT = { event = 2658 }
NOT = { event = 2659 }
random = 10
}

name = "fbarb_event8_name"
desc = "fbarb_event8_desc"

picture = "great_patriotic_war"
style = 0

date = { day = 13 month = december year = 1939 }
offset = 10 # Check for trigger conditions every 10 days
deathdate = { day = 1 month = may year = 1940 }

action_a = {
name = "OK"
command = { type = ground_def_eff value = 0.40 } # Rise to 0.7
command = { type = sleepevent which = 2660 } # Sleep natural rise
command = { type = sleepevent which = 2651 } # Sleep natural rise
command = { type = sleepevent which = 2652 } # Sleep natural rise
command = { type = sleepevent which = 2653 } # Sleep natural rise
command = { type = sleepevent which = 2654 } # Sleep natural rise
command = { type = sleepevent which = 2655 } # Sleep other GPW
command = { type = sleepevent which = 2657 } # Sleep other GPW
command = { type = sleepevent which = 2658 } # Sleep other GPW
command = { type = sleepevent which = 2659 } # Sleep other GPW

}
}

event = {
id = 2657
random = no
country = SOV

trigger = {
ai = no # human only
under_attack = SOV # any attack on USSR
NOT = { event = 2655 }
NOT = { event = 2656 }
NOT = { event = 2658 }
NOT = { event = 2659 }
random = 10
}

name = "fbarb_event8_name"
desc = "fbarb_event8_desc"

picture = "great_patriotic_war"
style = 0

date = { day = 2 month = may year = 1940 }
offset = 10 # Check for trigger conditions every 10 days
deathdate = { day = 1 month = may year = 1941 }

action_a = {
name = "OK"
command = { type = ground_def_eff value = 0.30 } # Rise to 0.7
command = { type = sleepevent which = 2660 } # Sleep natural rise
command = { type = sleepevent which = 2651 } # Sleep natural rise
command = { type = sleepevent which = 2652 } # Sleep natural rise
command = { type = sleepevent which = 2653 } # Sleep natural rise
command = { type = sleepevent which = 2654 } # Sleep natural rise

command = { type = sleepevent which = 2655 } # Sleep other GPW
command = { type = sleepevent which = 2656 } # Sleep other GPW
command = { type = sleepevent which = 2658 } # Sleep other GPW
command = { type = sleepevent which = 2659 } # Sleep other GPW

}
}

event = {
id = 2658
random = no
country = SOV

trigger = {
ai = no # human only
under_attack = SOV # any attack on USSR
NOT = { event = 2655 }
NOT = { event = 2656 }
NOT = { event = 2657 }
NOT = { event = 2659 }
random = 10
}

name = "fbarb_event8_name"
desc = "fbarb_event8_desc"

picture = "great_patriotic_war"
style = 0

date = { day = 2 month = may year = 1941 }
offset = 10 # Check for trigger conditions every 10 days
deathdate = { day = 1 month = may year = 1942 }

action_a = {
name = "OK"
command = { type = ground_def_eff value = 0.20 } # Rise to 0.7
command = { type = sleepevent which = 2660 } # Sleep natural rise
command = { type = sleepevent which = 2651 } # Sleep natural rise
command = { type = sleepevent which = 2652 } # Sleep natural rise
command = { type = sleepevent which = 2653 } # Sleep natural rise
command = { type = sleepevent which = 2654 } # Sleep natural rise
command = { type = sleepevent which = 2655 } # Sleep other GPW
command = { type = sleepevent which = 2656 } # Sleep other GPW
command = { type = sleepevent which = 2657 } # Sleep other GPW
command = { type = sleepevent which = 2659 } # Sleep other GPW
}
}

event = {
id = 2659
random = no
country = SOV

trigger = {
ai = no # human only
under_attack = SOV # any attack on USSR
NOT = { event = 2655 }
NOT = { event = 2656 }
NOT = { event = 2657 }
NOT = { event = 2658 }
random = 10

}

name = "fbarb_event8_name"
desc = "fbarb_event8_desc"

picture = "great_patriotic_war"
style = 0

date = { day = 2 month = may year = 1942 }
offset = 10 # Check for trigger conditions every 10 days
deathdate = { day = 30 month = december year = 1947 }

action_a = {
name = "OK"
command = { type = ground_def_eff value = 0.10 } # Rise to 0.7
command = { type = sleepevent which = 2660 } # Sleep natural rise
command = { type = sleepevent which = 2651 } # Sleep natural rise
command = { type = sleepevent which = 2652 } # Sleep natural rise
command = { type = sleepevent which = 2653 } # Sleep natural rise
command = { type = sleepevent which = 2654 } # Sleep natural rise
command = { type = sleepevent which = 2655 } # Sleep other GPW
command = { type = sleepevent which = 2656 } # Sleep other GPW
command = { type = sleepevent which = 2657 } # Sleep other GPW
command = { type = sleepevent which = 2658 } # Sleep other GPW
}
}

# AI gets instant ground_def boost in 36 GC
######################################

event = {
id = 2661
random = no
country = SOV
style = 0

trigger = {
ai = yes
}

date = { day = 1 month = january year = 1936 }
offset = 1
deathdate = { day = 3 month = january year = 1936 }

name = "AI_EVENT"

action_a = {
command = { type = ground_def_eff value = 0.60 } # 0.6 rise
command = { type = sleepevent which = 2651 }
command = { type = sleepevent which = 2652 }
command = { type = sleepevent which = 2653 }
command = { type = sleepevent which = 2654 }
command = { type = sleepevent which = 2655 }
command = { type = sleepevent which = 2656 }
command = { type = sleepevent which = 2657 }
command = { type = sleepevent which = 2658 }
command = { type = sleepevent which = 2659 }
}
}

# AI gets instant ground_def boost in 39 GC
######################################

event = {
id = 2663
random = no
country = SOV
style = 0

trigger = {
ai = yes
}

date = { day = 1 month = september year = 1939 }
offset = 1
deathdate = { day = 3 month = september year = 1939 }

name = "AI_EVENT"

action_a = {
command = { type = ground_def_eff value = 0.60 } # 0.6 rise
command = { type = sleepevent which = 2651 }
command = { type = sleepevent which = 2652 }
command = { type = sleepevent which = 2653 }
command = { type = sleepevent which = 2654 }
command = { type = sleepevent which = 2655 }
command = { type = sleepevent which = 2656 }
command = { type = sleepevent which = 2657 }
command = { type = sleepevent which = 2658 }
command = { type = sleepevent which = 2659 }
}
}

# AI gets instant ground_def boost in 41 GC
######################################

event = {
id = 2664
random = no
country = SOV
style = 0

trigger = {
ai = yes
}

date = { day = 21 month = june year = 1941 }
offset = 1
deathdate = { day = 23 month = june year = 1941 }

name = "AI_EVENT"

action_a = {
command = { type = ground_def_eff value = 0.10 } # 0.1 rise
command = { type = sleepevent which = 2651 }
command = { type = sleepevent which = 2652 }
command = { type = sleepevent which = 2653 }
command = { type = sleepevent which = 2654 }
command = { type = sleepevent which = 2655 }
command = { type = sleepevent which = 2656 }
command = { type = sleepevent which = 2657 }
command = { type = sleepevent which = 2658 }
command = { type = sleepevent which = 2659 }
}
}

# AI gets instant ground_def boost in 44 GC
######################################

event = {
id = 2665
random = no
country = SOV
style = 0

trigger = {
ai = yes
}

date = { day = 19 month = june year = 1944 }
offset = 1
deathdate = { day = 21 month = june year = 1944 }

name = "AI_EVENT"

action_a = {
command = { type = ground_def_eff value = 0.10 } # 0.1 rise
command = { type = sleepevent which = 2651 }
command = { type = sleepevent which = 2652 }
command = { type = sleepevent which = 2653 }
command = { type = sleepevent which = 2654 }
command = { type = sleepevent which = 2655 }
command = { type = sleepevent which = 2656 }
command = { type = sleepevent which = 2657 }
command = { type = sleepevent which = 2658 }
command = { type = sleepevent which = 2659 }
}
}

The only difference from the standard v1.3a code is that I've fixed the dates on the "under_attack" GDE jump events. Other than that... it should be identical to the v1.3a code.

It replaces the ENTIRE Great Patriotic War section... everything between the end of the "End of the Soviet-Romanian War - Romania refuse" (event 2638), and the beginning of "Spanish Civil War ends - An important experience (USSR)" (event 2662).

Remember to save the file afterward.

unmerged(51416) · Jan 30, 2006

blue emu said:
I don't use any Mods... so I don't know if it's compatible.

Assuming that you have v1.3b installed (although this SHOULD work with v1.3a too... haven't tested it):

Go into your:

>My Computer / Local Disk / Program Files / Paradox Interactive / Hearts of Iron 2 / db / events folder, and open (in Notepad) the ussr.txt file. You might want to paste a safe-copy of it onto your Desk-Top first, in case you mess something up.

Copy-and-Paste the following code over the ENTIRE Great Patriotic War section, near the end of your ussr.txt file... it REPLACES the existing code:

The only difference from the standard v1.3a code is that I've fixed the dates on the "under_attack" GDE jump events. Other than that... it should be identical to the v1.3a code.

It replaces the ENTIRE Great Patriotic War section... everything between the end of the "End of the Soviet-Romanian War - Romania refuse" (event 2638), and the beginning of "Spanish Civil War ends - An important experience (USSR)" (event 2662).

Remember to save the file afterward.

I have slighlty diffrent idea now. Probably the best solution (so it could work with any mod) is to create another file and place all the GDE events there there. I'll probably do it tomorrow.

And thanks a lot!

Dr. Shades · Feb 9, 2006

I'm still completely confused.

What is this flaw affecting? And if I don't fix this, what will go wrong?

unmerged(5892) · Feb 9, 2006

Dr. Shades said:
I'm still completely confused.

What is this flaw affecting? And if I don't fix this, what will go wrong?

It affects Russian GDE (ground defence efficiency). If you are playing without a fix, especially in 1.3b, you will often end up with an undefeatable Soviet Union.

blue emu · Feb 9, 2006

Dr. Shades said:
I'm still completely confused.

What is this flaw affecting? And if I don't fix this, what will go wrong?

"What will go wrong" depends on which patch you are using.

If you are using v1.3a, then the Great Patriotic War event will never fire... the dates are wrong. Russia's Ground Defense Efficiency will remain artificially low all through the war... creeping up by 0.1 each May, and will only reach 0.7 in 1943 (0.8 in 1944). That means that as Russia, you will be taking extra Manpower and ORG losses until those dates. If you are NOT playing Russia (and the AI is, instead), there's no problem... not under v1.3a.

If you are using v1.3b, it's much worse. Both an AI-Russia and a Human-Russia get boned by the v1.3b GPW bug. An AI-Russia will have their GDE boosted to 1.0 (more-or-less invulnerable, unless seriously dog-piled). A Human Russia will have it boosted to 3.7 or so... again, invulnerable.

This fix will prevent all that from happening... Russia's GDE will assume the correct values, AI or Human, before or after the Great Patriotic War event... which DOES now fire correctly, I've tested it.

Dr. Shades · Feb 10, 2006

blue emu said:
This fix will prevent all that from happening... Russia's GDE will assume the correct values, AI or Human, before or after the Great Patriotic War event... which DOES now fire correctly, I've tested it.

Thank you! But just to make sure I'm totally on-track now:

If I download and run the file at http://www.modhoi.com/downloads.htm, then will it automatically fix the GDE bug and the GPW bug?

Thanks in advance!

PackMan · Feb 10, 2006

Dr. Shades said:
Thank you! But just to make sure I'm totally on-track now:

If I download and run the file at http://www.modhoi.com/downloads.htm, then will it automatically fix the GDE bug and the GPW bug?

Thanks in advance!

The patch at www.modhoi.com only contains the GDE bug. I was not aware of any other when compiling it. If there is a GPW bug as well that should ofcourse be included as well.

Edit: Though reading the entire thread it seems it's one bug and not two. GDE (Ground Defense Efficiency) is changed through an event called GPW (Great Patriotic War). If so the patch with the bugfix should be ok

unmerged(38177) · Feb 27, 2006

Almost.... Bouncing back from referring post

Not to knock this info... because it does do the trick pretty much, but I noticed a "lazy day" approach in the event chain with regard to the "Sleep events". I am an ex-programmer (read "Ancient") and just like "clean code."

In the "Under Attack" series (events 2655 - 2659) events are tested for in the triggers section which are irrelevent. If any of these events fire, they "SLEEP" any of those other tested events. This means those "NOT" conditions will ALWAYS be true. Removing the "NOT" conditions cleans up the logic. I did this and didn't change the dates, and it seems to work correctly. Also, this series 'should' sleep the AI series (events 2661 - 2665) since they could fire after an "under attack" event, effectively getting a DOUBLE GDE BOOST. I think I have read about people encountering this.

Missed is the fact that the AI series (events 2661 - 2665) sleep the non-AI events, but not the AI series itself. This means that additional events will fire, making SOV AI much harder than it should be (at least by my reading of the code.) Each of these events should sleep the successive events.

Finally, (and this is a nidpick), the Standard series (events 2660, 2651 - 2654) do not need to sleep events that have already past their death dates. Further, they sleep "under attack" events that have already been slept by prior standard events (event 2655 receives the "Sleepevent" command no fewer than six times! Completely unnessasary)

blue emu · Feb 27, 2006

I noticed that too... but I didn't want to completely re-write the Paradox code, so I settled for just finding the error that was preventing the GPW events from firing properly (the wrong dates!) and fixed that.

I've tested this fix in a number of USSR games... and the GPW events now fire correctly.

It would be better, of course, to have the initial 1936 AI event sleep all the non-AI events... and vice versa... so that you won't get caught both coming and going if you happen to re-load as a different country for some reason (eg: to force Germany into Barbarossa).

It's a shame that Paradox has not released a proper fix for this... it's not exactly a trivial problem.

unmerged(13745) · Feb 27, 2006

So for us that are stupid..

If we applied the GDE fix located at click me would we then need to apply this new fix by you Blue emu?

6354201 · Feb 27, 2006

Some mod needs to sticky this.

Paradox should have checked over the code more thoroughly and play tested it so that this mess could have been avoided. If they didn't have the time to get it right, it should never have been included in a patch. It added nothing of positive value to the game as it is w/out fixing the events. The worst aspect of this however is that for the people who do not read the forums and are thus unawares of the problem are having to put up with a massively flawed event chain for one of the world's major powers.

unmerged(38177) · Feb 27, 2006

6354201 said:
Paradox should have checked over the code more thoroughly and play tested it so that this mess could have been avoided. If they didn't have the time to get it right, it should never have been included in a patch. It added nothing of positive value to the game as it is w/out fixing the events. The worst aspect of this however is that for the people who do not read the forums and are thus unawares of the problem are having to put up with a massively flawed event chain for one of the world's major powers.

I really have to come to the defence (somewhat) of "Johan and company" in this area. If you read back you will find so many requests for implementation that one must question how they can "Keep Up", therefore an "Enhancement is ready WHEN it is ready." This code block should have been tested better, but they were probably trying to overcome the overpowering Soviet army. It was commonplace for SU to take over China and/or Japanese Korea prior to 1937 with almost no resistance ( 1940 Motorized Infantry and tanks vs 1918 Infantry and Militia.) While I do not like how this fix works out, I do appreciate the attempt.

In counter to this, I would imagine "Johan and Company" have spent the "Lion's Share" of time implementing "Doomsday enhancements" to the code, to the neglect of proper testing procedures on "Vanilla" HOI2. The logic errors in the entire "Great Patriotic War" event chain are just too overwelming to be totally signed-away as a "minor error", however once the 1.3a version was released, the 1.03b should have worked properly.

blue emu · Feb 27, 2006

Kausten said:
So for us that are stupid..

If we applied the GDE fix located at click me would we then need to apply this new fix by you Blue emu?

Unfortunately, I've never used... or even downloaded... that other fix, since I simply fixed it myself once I became aware of the problem.

I've been told that the other fix works just as it is... but I cannot personally vouch for that.

I've figured it out! v1.3a GPW bug...

GroFAZ

First Lieutenant

Second Lieutenant

Major

Dominus et Deuculus

Slayer of many Dixie-folk

Dominus et Deuculus

GroFAZ

Dominus et Deuculus

Corporal

Fourth Internationalist

GroFAZ

Corporal

Code Monkey

Colonel

GroFAZ

Vampire

General

Colonel

GroFAZ