Hello, I was originally working on the Cultures Expanded compatch I was talking about but the mod became outdated and unplayable by the two most recent patches and I decided to hold off until it was updated.
Hi, thank you for an update on the progress. It's unfortunate that the standalone version of the mod fell behind with the updates. However, the version that requires EPE is up-to-date with CK3 1.11:
https://steamcommunity.com/workshop/filedetails/?id=2829397295. Do you know if it'd possible to use your work for that version? I could work on adding the EPE compatibility part to the converter myself.
In the mean time, I thought to start culture mapping WTWSMS since compatibility is planned for the future and it used to work (as in not immediately crash). Although it doesn't seem to work anymore (at least not with the beta), I did noticed that there were overlapping cultures liked what happened with Iberian. Since they were from two separate mods and not the converter they couldn't be fixed manually in the same way. I tired to implement something similar to what the ck2 to eu4 converter does where a separate set of certain configuration files are used when a certain mod is loaded to fix the overlap. It seems to be working with TFE although the configurations themselves aren't done except for tests changes.
WtWSMS hasn't been compatched for CK3 1.11, maybe it will work again when it's updated.
As for the overlapping cultures, could you provide an example of a conflict between TFE and WtWSMS that will be problematic? In case it's a matter of the two mods using a single culture ID for representing two separate things, I'll use a made-up, but plausible example:
- WtWSMS has "illyrian" culture that represents ancient Illyrians.
- TFE has "illyrian" culture that represents Romano-Illyrians.
- We need separate links in culture_map.txt. For that, I can add a new parameter to make a distinction by using selected mods (probably the best option), heritages, or something else:
-
Code:
# there would be a predefined list of mod flags, for example: tfe, wtwsms, more_bookmarks_plus
link = { ir=illyrian ck3=ancient_illyrian } # TFE
link = { ir=illyrian ck3=illyrian has_mod=wtwsms } # WtWSMS
link = { ir=illyrian ck3=albanian } # vanilla CK3
link = { ir=romano_illyrian ck3=romano_illyrian } # WtWSMS
link = { ir=romano_illyrian ck3=illyrian has_mod=tfe } # TFE
link = { ir=romano_illyrian ck3=roman } # WtWSMS and vanilla CK3
or
Code:
link = { ir=illyrian ck3=ancient_illyrian } # TFE
link = { ir=illyrian ck3=illyrian has_heritage=heritage_illyrian } # WtWSMS
link = { ir=illyrian ck3=albanian } # vanilla CK3
link = { ir=romano_illyrian ck3=romano_illyrian } # WtWSMS
link = { ir=romano_illyrian ck3=illyrian has_heritage=heritage_latin } # TFE
link = { ir=romano_illyrian ck3=roman } # vanilla CK3
In my opinion, having separate mapping files for each mod would be hard to maintain. If Imperator: Invictus added a new culture, it would need to be added to multiple files.
By using a single mapping file with optional parameters, we can avoid the duplication and only add special cases when there's a conflict between mods.
Does my idea make sense, or am I missing something that makes this unfeasible?
This has been a bit of a rant but I want to ask if this is something you guys would even want in the first place since it's a much more substantial change than basic mapping that I've contributed before? I want to note that this was done in a slightly outdated version from a manual download in visual studio so I don't exactly know how I would hand it off to you without needing to redo it in GitHub or overriding some stuff. Also like a year out of practice of c# when I started so I don't know if it's up to par with the rest of the converter's code or not.
You can send your source code in a zip I'll compare the changes. Don't worry about the code quality. If you're also interested in implementing other missing features in the converter, I could help you get accustomed to the project the way Idhrendur and Zemurin helped me in the beginning
.
We could chat faster on our Discord server related to all the converters. If you'd like to join, I will send you an invite.