HoI 4 - USA Congress building requests not completing (including some bug qualification) [1.10.8][0aab]

[Kaerid]

Description of issue
USA Congress building requests not completing (including some bug qualification) [1.10.8][0aab]

Game Version
1.10.8

Enabled DLC
Together for Victory, Death or Dishonor, Waking the Tiger, Man The Guns

Do you have mods enabled?
No

Description
I had the "congress wants to invest in munitions factory" event (usa.62 from events/USA.txt) trigger, targetting North Carolina which had 0 mil factories.
Before finishing the construction, a national focus (Arsenal of Democracy) added 3 mil factories in that state.

Neither the 3 factories from the focus nor the ones I built later triggered the event completion.

Checking with commands, I could see that the variable 363.arms_factory_goal had a value of 1 (363 being the id for N.Carolina). This was the expected value since the state originally had 0 mil.

However, the trigger condition for completion (from common/decisions/MTG_congress.txt ) is:
check_variable = { arms_factory_goal = arms_factory_level }
which does not validate in my case since the arms_factory_level jumped from 0 to 3 without going through the expected 1.

Using commands to set 363.arms_factory_goal to the current factory level (5 when I tried) did validate the decision, so this issue seems limited to the check from above which only validates strict equality.


Since the code is similar, this issue probably applies to the civ factory, dockyard and infrastructure variants as well.

Steps to Reproduce
No reliable way to reproduce: if the analysis is correct, it requires free buildings from a national focus to target the same state & same building type as the congress event, so this is quite RNG-dependent.

Upload Attachment
File(s) attached

 

[doubleskulls]

I may have seem something similar. I play the game to pause on event, and whenever this event fired in that I always put the requested item to the top of the infra queue, but this never resulted in the gain. It seems that waiting 1 day to tick over before starting the building means you get the benefit.

 

[TomPorter]

I may have seem something similar. I play the game to pause on event, and whenever this event fired in that I always put the requested item to the top of the infra queue, but this never resulted in the gain. It seems that waiting 1 day to tick over before starting the building means you get the benefit.

Thanks for the tip, I'll try that and see if it works for me. It's interesting that this issue has been around for so long and not fixed. Infrastructure, docks and factories don't complete that often, it seems reasonable that a check could be performed to see if any outstanding events are active and if so set it to completed.