HoI 4 - Manchukuo White Peace With Japan Error and Border Conflict Still Using Terrain Modifier (1.12.4.3887 - cb616)

[kiamhiung]

Description of issue
Manchukuo White Peace With Japan Error and Border Conflict Still Using Terrain Modifier (1.12.4.3887 - cb616)

What platform do you play on?
Steam

Game Version
1.12.4.3887

Enabled DLC


Do you have mods enabled?
No

Description
when i play as manchukuo and choosing independence path, white peace is not happening between Manchukuo and Japan if China already white peace first, all my gained territory return to China, and Manchukuo and Japan still at war. If i joined China faction, when the white peace happened the territory revert to prewar, no Korea, Mengkukuo exist again, although Manchukuo peace out with Japan.

and another issue, when playing with warlords and using border conflict mechanics, attack now have terrain modifier. it make border conflict almost unwinnable.

Steps to Reproduce
play Man or Warlord normally, For MAN just tried backstabbing Japan until China get white peace.

Upload Attachment
File(s) attached

 

[papapyro]

This has also just happened in my game; Japan lost its last territory on the mainland and white peaced China, but now I'm stuck at war with them, ruining the campaign.

 

[papapyro]

Just looking at the decision files and saw this:

JAP_sue_for_peace_MAN = {
...
        ai_will_do = {
            base = 10
            modifier = {
                factor = 0
                casualties_inflicted_by = {
                    opponent = MAN
                    thousands < 300
                }
            }
...
    }

I don't remember seeing this 'casualties_inflicted_by' line before; is it a new addition? If so, might it be causing the problem?
What does it even mean? Japan won't peace out until it loses 300,000 men to Manchukuo? I'm pretty sure I'd killed >500,000 of them but still didn't get them to peace out.

 

[Mefisto1029]

Just looking at the decision files and saw this:

JAP_sue_for_peace_MAN = {
...
        ai_will_do = {
            base = 10
            modifier = {
                factor = 0
                casualties_inflicted_by = {
                    opponent = MAN
                    thousands < 300
                }
            }
...
    }

I don't remember seeing this 'casualties_inflicted_by' line before; is it a new addition? If so, might it be causing the problem?
What does it even mean? Japan won't peace out until it loses 300,000 men to Manchukuo? I'm pretty sure I'd killed >500,000 of them but still didn't get them to peace out.

The problem is not this modifier, but the next one.

            modifier = {
                factor = 0
                NOT = {has_country_flag = JAP_dont_surrender_instantly_lock}
            }

Because it will always be factor = 0 unless Japan completes the Finish the Fight national focus.
It should be instead:

            modifier = {
                factor = 0
                has_country_flag = JAP_dont_surrender_instantly_lock
            }

Both of these mods were added in version 1.12.0

 

[papapyro]

The problem is not this modifier, but the next one.

            modifier = {
                factor = 0
                NOT = {has_country_flag = JAP_dont_surrender_instantly_lock}
            }

Because it will always be factor = 0 unless Japan completes the Finish the Fight national focus.
It should be instead:

            modifier = {
                factor = 0
                has_country_flag = JAP_dont_surrender_instantly_lock
            }

Both of these mods were added in version 1.12.0

Goddamnit Paradox...