HoI 4 - All nations do NOT have Illusive gentemen

[Palaiologos]

Description of issue
All nations do NOT have Illusive gentemen

Game Version
latest beta

Enabled DLC
All of the above

Do you have mods enabled?
No

Description
Hungary, and I guess others, have the same problem with the illusive gentleman advisor(apperas and dissappears). There is an error in the trigger text file, a guy posted it yesterday IIRC.

Steps to Reproduce


Upload Attachment

 

[pyrofreakpenguin]

I can confirm.

Ran a few games of Portugal really quick. The Illusive Gentleman exists at the start of the game but will disappear from the list around the time I build the intelligence agency.

 

[Dan1109]

$ awk '/head_of_intelligence/ { if (a) print a; if (b) print b; if (c) print c; if (d) print d; if (e) print e;if (f) print f;} {a=b;b=c;c=d;d=e;e=f;f=$0;}' *

                        allowed = {
                                original_tag = ENG
                                has_dlc = "La Resistance"
                        }

                                        original_tag = CHI
                                        is_chinese_warlord = yes
                                }
                                has_dlc = "La Resistance"
                        }


                        allowed = {
                                original_tag = PRC
                                has_dlc = "La Resistance"
                        }


                        allowed = {
                                original_tag = FRA
                                has_dlc = "La Resistance"
                        }


                        allowed = {
                                original_tag = GER
                                has_dlc = "La Resistance"
                        }


                        allowed = {
                                original_tag = ITA
                                has_dlc = "La Resistance"
                        }


                        allowed = {
                                original_tag = JAP
                                has_intelligence_agency = yes
                        }


                        allowed = {
                                original_tag = POL
                                has_dlc = "La Resistance"
                        }


                        allowed = {
                                original_tag = SOV
                                has_dlc = "La Resistance"
                        }


                        allowed = {
                                original_tag = USA
                                has_dlc = "La Resistance"
                        }

JAP is the only country with the bug. Any other country not listed here simply doesn't have the advisor. @podcat stated that they were planning to give access to the advisor to all nations, but I guess it wasn't done yet in the current hotfix (they'll have to add advisor to all nations, and come up with unique names)

 

[pyrofreakpenguin]

This bug is for the beta patch available now of Steam, 1.9.1_beta. See the changelog for balance:

- every country should now have access to a minister to unlock an extra operative slot

Activating that patch, you will have access to an Illusive Gentleman.

generic_head_of_intelligence = {
            allowed = {
                has_dlc = "La Resistance"
                NOT = {
                    OR = {
                        tag = XSM
                        tag = SIK
                        tag = SHX
                        tag = YUN
                        tag = GXC
                    }
                }
            }
            visible = {
                NOT = {
                    has_available_idea_with_traits = { idea = head_of_intelligence limit = 1 } #welcome to Gabriel's shitty script solution corner. This means this thing will be in a bunch of countriies' database, just not shown, which will no doubt cause absolutely no issues and doesn't impact performance
                }
            }
            available = {
                has_intelligence_agency = yes
            }
            traits = { head_of_intelligence }

            ai_will_do = {
                factor = 1
                modifier = {
                    has_intelligence_agency = no
                    factor = 0
                }
            }
        }

Also note the wonderful comment.

 

[Dan1109]

I can confirm.

Ran a few games of Portugal really quick. The Illusive Gentleman exists at the start of the game but will disappear from the list around the time I build the intelligence agency.

Are you certain? I just started a '36 Portugal game and I did not see the advisor immediately on start up. From the code before and below, this shows the countries that are currently allowed to have the advisor:

$ grep head_of_intel *
britain.txt:                    traits = { head_of_intelligence }
china.txt:                      traits = { head_of_intelligence }
comchina.txt:                   traits = { head_of_intelligence }
france.txt:                     traits = { head_of_intelligence }
germany.txt:                    traits = { head_of_intelligence }
italy.txt:                      traits = { head_of_intelligence }
japan.txt:                      traits = { head_of_intelligence }
poland.txt:                     traits = { head_of_intelligence }
soviet.txt:                     traits = { head_of_intelligence }
usa.txt:                        traits = { head_of_intelligence }

 

[Dan1109]

Are you certain? I just started a '36 Portugal game and I did not see the advisor immediately on start up. From the code before and below, this shows the countries that are currently allowed to have the advisor:

$ grep head_of_intel *
britain.txt:                    traits = { head_of_intelligence }
china.txt:                      traits = { head_of_intelligence }
comchina.txt:                   traits = { head_of_intelligence }
france.txt:                     traits = { head_of_intelligence }
germany.txt:                    traits = { head_of_intelligence }
italy.txt:                      traits = { head_of_intelligence }
japan.txt:                      traits = { head_of_intelligence }
poland.txt:                     traits = { head_of_intelligence }
soviet.txt:                     traits = { head_of_intelligence }
usa.txt:                        traits = { head_of_intelligence }

OK, I'm not running 1.9.1 yet

 

[pyrofreakpenguin]

The original report could have been clearer on the version.

Screenshot for general reference.

 

[Dan1109]

I can confirm.

Ran a few games of Portugal really quick. The Illusive Gentleman exists at the start of the game but will disappear from the list around the time I build the intelligence agency.

OK, so your bug is with 1.9.1 and has the advisor appearing, then disappearing, being quite illusive. I'd say the problem is the with VISIBLE statement, as that it what got JAP into trouble in the first place. Quite ironic its with that specific statement.

 

[Dan1109]

So, just loaded 1.9.1. It looks like they did not fix Japan, as it is still using the VISIBLE statement, unlike the other majors where it works fine. Further they used the VISIBLE statement on the zzz_generic.txt countries, giving them similar problems with Japan. Looks like the VISIBLE statement is unreliable at best.

 

[Altair.1689]

steps to reproduce
create an inteligence agency, once you do that the illusive gentleman will disappear.

edit: so eliminating the VISIBLE paragrahp should keep the illusive gentlemen without dissapearing once you create de agency(it seems)

 

[Palaiologos]

The original report could have been clearer on the version.

well in my defence, I did write the "latest beta" in the OP.

 

[podcat]

hmm yeah looks like the visible setting will turn off because you unlock the actual minister too. probably needs a check if thats happened. Thanks for the catch!

 

[podcat]

We ended up needing a code fix for this case. it should be in the next open beta updae

 

[Dan1109]

We ended up needing a code fix for this case. it should be in the next open beta updae

cool, so VISIBLE now works correctly then and can be used without worries by modders?