HoI 4 - [1.11.12.82b4] [22d5] Mexican Fascist election cannot elect Salvador Abascal

[Dryhad]

Description of issue
[1.11.12.82b4] [22d5] Mexican Fascist election cannot elect Salvador Abascal

Game Version
1.11.12.82b4 (22d5)

Enabled DLC


Do you have mods enabled?
No

Description
Attempting to choose Abascal as candidate for the 1940 election shows a tooltip of Abascal becoming leader, but this does not occur. In the transition to the new character system, some logic has been set up to display a cosmetic tooltip in allowance for the fact that Abascal begins the game with a scripted country leader role, but functional script to promote him was neglected.

It should be sufficient to add something to the relevant section of event mexico.19 along the lines of

MEX_Salvador_Abascal = {
	promote_character = falangism
}

Note also this thematically connected bug is still in effect.

Steps to Reproduce
Take the following focuses:
- Plan of Agua Prieta
- Jefe Maximo
- Legacy of Revolution
- The Gold Shirts
- Revanchist Revolution

Wait until the 1940 election.
Abascal will be a potential candidate (possibly the only one, depending on other focuses taken)
Selecting Abascal in this event leaves Calles as leader.

Upload Attachment
File(s) attached

 

[Mefisto1029]

Yeah there is problem.

Spoiler: Current Code

    option = { # Falangist candidate: Salvador Abascal
        name = mexico.19.q
        
        trigger = {
            NOT = {
                has_country_leader = {
                    character = MEX_salvador_abascal
                }
            }
            has_government = fascism
        }
        if = {
            limit = {
                has_country_leader = { #If he is already country leader, fake tooltip
                    character = MEX_salvador_abascal
                    ruling_only = no
                }
            }
            effect_tooltip = {
                add_country_leader_role = {
                    character = MEX_salvador_abascal
                    country_leader = {
                        expire = "1965.1.1"
                        ideology = falangism
                        traits = {
                            fascist_militia_leader
                        }
                    }
                    promote_leader = yes
                }
            }
        }
        else = {
            add_country_leader_role = {
                character = MEX_salvador_abascal
                country_leader = {
                    expire = "1965.1.1"
                    ideology = falangism
                    traits = {
                        fascist_militia_leader
                    }
                }
                promote_leader = yes
            }
        }
    }

But it can be fixed and a lot smaller.

Spoiler: Fixed

    option = { # Falangist candidate: Salvador Abascal
        name = mexico.19.q
        
        trigger = {
            NOT = {
                has_country_leader = {
                    character = MEX_salvador_abascal
                }
            }
            has_government = fascism
        }
        
        promote_character = { character = MEX_salvador_abascal  ideology = falangism }
    }

Note that trigger will only happens when he is not leader, so we don't need whole fake tooltip part, because we wont see this option anyway.
Second part... he already have country leader role so we dont need to add new/another, we just need to promote him.