Fixed in 1.03: test on has_improvement broken

[richvh]

test on has_improvement broken

Testing on has_improvement of this form:

condition = {
   type = has_improvement
   value = { church = no }
}

always returns true, whether or not the improvement exists in the province. This currently only affects a few usury events in Religious_Events.txt, all other tests on has_improvement use the form:

condition = {
   type = has_improvement
   value = { church = yes }
}

which works properly. has_advance seems to work correctly for both = yes and = no forms, I haven't tested the other has_* tests.

 

[kurtbrian]

can others confirm this?

 

[richvh]

It's easy to test - trigger event 1958 from the console (attract moneylenders) while you already have a moneylender building in the province. It should - but won't - say never happen, trigger not satisfied.

 

[Cat Lord]

The workaround:

condition = {
	type = not
	value ={
		type = has_improvement
		value = { moneylenders = yes }
	}
}

do the trick, so I am not sure this one will be corrected.

Maybe I should update the event effect.txt again for this one.

Cat

 

[richvh]

Yes, it does, and as far as I know the only Paradox event this affects is 1458 Moneylenders Attracted.

 

[Cat Lord]

Yes, it does, and as far as I know the only Paradox event this affects is 1458 Moneylenders Attracted.

In this case, we will probably correct the event, not the effect...

Cat

 

[richvh]

Make that event 1958 (bad memory! Bad! Bad! Bad!)

 

[unmerged(6777)]

Fixed in 1.03

 

[richvh]

Is that "events rewritten to avoid buggy code" fixed or "buggy code corrected" fixed, for future reference?

 

[State Machine]

Bah! Like we would ever tell...

Anyway T has judged and so all is cool...

 

[unmerged(6777)]

Is that "events rewritten to avoid buggy code" fixed or "buggy code corrected" fixed, for future reference?

Decision was made to go with [improvment] = yes and use a not statement to invert it...this is for consistancy in scripting sake so you don't have to remember which arguments take "= no" as valid.