• We have updated our Community Code of Conduct. Please read through the new rules for the forum that are an integral part of Paradox Interactive’s User Agreement.

RaTeFS

Private
46 Badges
Oct 30, 2009
20
2
  • Crusader Kings II
  • Victoria 2: Heart of Darkness
  • Victoria 2: A House Divided
  • Semper Fi
  • Rome Gold
  • Victoria: Revolutions
  • Europa Universalis IV: Res Publica
  • Heir to the Throne
  • Hearts of Iron III: Their Finest Hour
  • Hearts of Iron III
  • For the Motherland
  • For The Glory
  • Europa Universalis IV: Art of War
  • Divine Wind
  • Europa Universalis III Complete
  • Crusader Kings II: The Republic
  • Cities in Motion
  • Hearts of Iron IV: Together for Victory
  • Cities: Skylines - Mass Transit
  • Knights of Honor
  • Europa Universalis 4: Emperor
  • Surviving Mars
  • Europa Universalis IV: Rights of Man
  • Hearts of Iron IV: Death or Dishonor
  • Hearts of Iron IV: Expansion Pass
  • Cities: Skylines - Parklife
  • Surviving Mars: First Colony Edition
  • Cities: Skylines Industries
  • Hearts of Iron IV: Expansion Pass
  • Surviving Mars: First Colony Edition
  • Crusader Kings III
  • Hearts of Iron IV: Cadet
  • Hearts of Iron IV Sign-up
  • Europa Universalis IV: Mare Nostrum
  • Crusader Kings II: Conclave
  • Cities: Skylines - After Dark
  • Europa Universalis IV: Common Sense
  • Crusader Kings II: Way of Life
  • 500k Club
  • Victoria 2
  • Europa Universalis III Complete
  • Europa Universalis III Complete
  • Europa Universalis IV
  • Cities: Skylines
  • Europa Universalis IV: Conquest of Paradise
  • Crusader Kings II: Legacy of Rome
While combing through some game files I found this:

When completing the Communist China Focus 'Government of National Defense' an Event 'wtt_prc.1' is triggered - which is the first one in 'WTT_PRC.txt'.
Here one can find this (starting) in line 48:

Code:
if = {
                limit = {
                    NOT = { is_in_faction_with = FROM }
                    FROM = { is_in_faction = no }
                }
                FROM = {
                    set_rule = { can_create_factions = yes }
                    create_faction = PRC_government_of_national_defense
                }
            }

Shouldn't this say 'ROOT' instead of 'FROM' in the third line of the snippet? It would be the same as some lines above while checking for Focus 'Coalition Goverment'.
Or is everything right just as it is?

Thanks for reading, folks.
 
While combing through some game files I found this:

When completing the Communist China Focus 'Government of National Defense' an Event 'wtt_prc.1' is triggered - which is the first one in 'WTT_PRC.txt'.
Here one can find this (starting) in line 48:

Code:
if = {
                limit = {
                    NOT = { is_in_faction_with = FROM }
                    FROM = { is_in_faction = no }
                }
                FROM = {
                    set_rule = { can_create_factions = yes }
                    create_faction = PRC_government_of_national_defense
                }
            }

Shouldn't this say 'ROOT' instead of 'FROM' in the third line of the snippet? It would be the same as some lines above while checking for Focus 'Coalition Goverment'.
Or is everything right just as it is?

Thanks for reading, folks.
Both the checks in line 26 and 49 don't make a whole lot of sense:
  • NOT = { is_in_faction_with = ROOT } is a more convoluted way of saying is_in_faction = no
  • NOT = { is_in_faction_with = FROM } is a subset condition of FROM = { is_in_faction = no } because ROOT can't be in a faction with FROM if FROM is not in a faction at all
So ideally they both get changed, but I agree that the one you quoted is "more wrong" because it really only checks one thing when probably two different checks were intended.
 
  • 1
  • 1
Reactions: