conscription_factor changes do not always add manpower with British Raj foci [v1.3.0, 5256]

[Jamey]

Indian Gurkhas and Lions of the Great War do not always give any manpower to the Raj when selected.

Replication steps:

1. Start a game as the Raj in the 1939 scenario (so that all Foci are readily available).
2. Use research_on_icon_click to add Mountain Infantry I (for Gurkhas)
3. Select Indianisation of Army, Indian Gurkhas, and Lions of the Great War
4. Note that whichever of Indian Gurkhas and Lions of the Great War is selected first adds no manpower

After playing around with selecting the different Raj foci which change conscription_factor, my working theory is that conscription_factor changes only add manpower when they change the country's conscription_factor past a multiple of 5%. If so, this likely impacts other nations as well.

 

[Jamey]

Upon further, more detailed, review, conscription_factor seems to be even more crazy than I thought. I can't for the life of me figure out what it is doing.

Here are all of the manpower/conscription_factor permutations available from the India NF tree:

conscription_factor    Manpower    Modifier    Theoretical Modifier
11%    330,120    100.00%    100.00%
13%    330,120    100.00%    118.18%
15%    660,960    200.22%    136.36%
16%    660,960    200.22%    145.45%
18%    660,960    200.22%    163.64%
20%    981,100    297.19%    181.82%
21%    981,100    297.19%    190.91%
23%    981,100    297.19%    209.09%
25%    981,100    297.19%    227.27%
26%    981,100    297.19%    236.36%
28%    1,310,000    396.83%    254.55%
30%    1,310,000    396.83%    272.73%

 

[Jamey]

It looks like the problem is rounding of the manpower percentage from conscription laws multiplied with conscription_factor:

conscription_factor    Manpower    Modifier    Theoretical Modifier    Modified MP Percent    Modified MP Percent Rounded    Modified MP Rounded
11%    330,120    100.00%    100.00%    0.17%    0.001    330,120
13%    330,120    100.00%    118.18%    0.20%    0.001    330,120
15%    660,960    200.22%    136.36%    0.23%    0.002    660,240
16%    660,960    200.22%    145.45%    0.24%    0.002    660,240
18%    660,960    200.22%    163.64%    0.27%    0.002    660,240
20%    981,100    297.19%    181.82%    0.30%    0.003    990,360
21%    981,100    297.19%    190.91%    0.32%    0.003    990,360
23%    981,100    297.19%    209.09%    0.35%    0.003    990,360
25%    981,100    297.19%    227.27%    0.38%    0.003    990,360
26%    981,100    297.19%    236.36%    0.39%    0.003    990,360
28%    1,310,000    396.83%    254.55%    0.42%    0.004    1,320,480
30%    1,310,000    396.83%    272.73%    0.45%    0.004    1,320,480

 

[Niko92]

conscription_factor is a modifier applied to your conscription level. So at volunteer army and with the agrarian society (-69% factor), you're getting 5% * (1-0.69) = 1.55% of your entire population. Several conscription_factors are additive I think.

I don't know if that answers your question, but it's early morning and I'm having a hard time understanding your tables .

 

[Jamey]

conscription_factor is a modifier applied to your conscription level. So at volunteer army and with the agrarian society (-69% factor), you're getting 5% * (1-0.69) = 1.55% of your entire population. Several conscription_factors are additive I think.

I don't know if that answers your question, but it's early morning and I'm having a hard time understanding your tables .

Actually, with volunteer level and only the Agrarian Society modifier, you get 1.5% * (1 - 0.69) = 0.47%, which the game is rounding down to 0.4%.

That rounding is exactly the bug I'm talking about.