CK2Plus - Report a Bug

[vukica]

So I have the whole low crown authority destroying titles thing turned off but the Latin Empire keeps getting destroyed after a few years no matter what I do, even using commands to boost the authority up. Any ideas what's causing that?

Different religion of the ruler?

 

[DreadGrunt]

Different religion of the ruler?

That might be it, yeah. Think I might have chosen an Orthodox heresy or something during character creation. I'll check again a bit later and let you know if that's what it was.

 

[Furiously Eloquent]

While playing a tribal Iceland game starting 867 (unreformed pagan), I managed to become a ravager without capturing a single prisoner. Typically I was using an unlanded commander with the siege_leader trait, also unreformed pagan. Afterwards, I dug into your siege code and discovered a significant amount of bugs/logic issues. I will likely be creating a sub-mod or similar regarding various siege/tribal/pagan interactions with features I want, but wanted to pass any bug fixes upstream if possible. What is the best way for me to do so?

Incomplete list of issues found

• Events 1021 and 1031 have numerous any_character scopes that are inefficient and also do not handle the case where the holder is at another location due to leading troops or performing councilor duties
• All of the various scripted effects called recursively suffer an issue, in that they themselves call another event in the immediate section (events 1027 and 1028), which prevents any additional recursive enumeration as those called events do not return. Adding days = 1 to event calls in the scripted effects resolves this. Practically this means only 1 character can be taken prisoner or killed in any siege.
• [Apparent Vanilla Issue] It seems war_with is not commutative, at least in regards to raiding. Replacing with an OR that tests both cases seems to function as expected.

Also this in the regards to the most recent 4.07 Beta6. Thanks for everything.

 

[zeress]

While playing a tribal Iceland game starting 867 (unreformed pagan), I managed to become a ravager without capturing a single prisoner. Typically I was using an unlanded commander with the siege_leader trait, also unreformed pagan. Afterwards, I dug into your siege code and discovered a significant amount of bugs/logic issues. I will likely be creating a sub-mod or similar regarding various siege/tribal/pagan interactions with features I want, but wanted to pass any bug fixes upstream if possible. What is the best way for me to do so?

Incomplete list of issues found

• Events 1021 and 1031 have numerous any_character scopes that are inefficient and also do not handle the case where the holder is at another location due to leading troops or performing councilor duties
• All of the various scripted effects called recursively suffer an issue, in that they themselves call another event in the immediate section (events 1027 and 1028), which prevents any additional recursive enumeration as those called events do not return. Adding days = 1 to event calls in the scripted effects resolves this. Practically this means only 1 character can be taken prisoner or killed in any siege.
• [Apparent Vanilla Issue] It seems war_with is not commutative, at least in regards to raiding. Replacing with an OR that tests both cases seems to function as expected.

Also this in the regards to the most recent 4.07 Beta6. Thanks for everything.

Compile the fixes into the relevant files, zip them and upload it here. We can figure it out from there.

 

[Furiously Eloquent]

Ok, I believe I've stripped out any additional features or logging I made, save for clear bug fixes. I'll keep a branch open specifically for bugs I find in the future.

Sorry about the loss of path information in the zip, the relative paths and filenames are ./events/CK2Plus_siege_events.txt and ./common/scripted_effects/plus_scripted_effects.txt

I hope to have a sub-mod for sieging/raiding/tribal/early game balance fully together and on the forums within the next 2 weeks.

 

[zazenzach]

This is weird. I had the Sultanate of Mesopotamia (a Kingdom) randomly become the primary title of the Abbassids when the Arabian Empire (an Empire) still existed. I saved the game and reloaded in as the abbassids. I tried to make the Arabian Empire the primary title again but it wont let you. Did some random chain of events occur or is this a bug?

 

[cchiu23]

latin culture in the 'crusader' culture group has been split in two

in the first latin culture listed, the only last name that can be randomly generated is smith

in the second latin culture listed, the only first name that can be randomly generated is adam

 

[tylonator]

Date: 1 January, 1158 and onwards
Character: Duke Somerled of Søreyar of House Somhairle (Duchy of Søreyar, Kingdom of Norway (Modern day isle of Scotland and Argyll)

Problem: House Somhairle (Scottish Family) has a 'Main Line' which consists of two members who have never held titles, both deceased, and the 'Secondary Line' which holds titles but are shown as disconnected Kinsman of the family. You can see this when you click on the family crest to view the family tree. At later dates the descendants of Somerled pile up on the left of the tree with no connections showing descent.

Current Family
Main line:
Gilbride Somhairle B. 1 January, 1089, D. 1 January, 1136 - No Titles
- Daughter - Effie Somhairle B. 1 January, 1118, D. 1 January, 1152 - No Titles, no children

Secondary line:
Duke Somerled of Søreyar (Duke and Thanage of Søreyar, Thanage of Argyll
- Wife - Duchess Ragnhild of Søreyar (House of Crovan)
- Sons - Ragnall, Dugald, Angus Mac Somerled

In Vanilla these lines are actually one family. Gilbride is the father of both Effie and Somerled. Effie was also married to Earl Malcolm of Ross (House Mc Aeda) with a daughter (Hvorflaed) and a son (Adam)

This has popped up since the release of the Jade Dragon DLC and is still in the latest Beta of CKII +

 

[vukica]

latin culture in the 'crusader' culture group has been split in two

in the first latin culture listed, the only last name that can be randomly generated is smith

in the second latin culture listed, the only first name that can be randomly generated is adam

Try deleting the old version of the mod before installing the new one.
You know, just like it says in the instructions.

There's no such bug and it could only happen by mixing old and new files.

 

[LordPeter]

Date: 1 January, 1158 and onwards
Character: Duke Somerled of Søreyar of House Somhairle (Duchy of Søreyar, Kingdom of Norway (Modern day isle of Scotland and Argyll)

Problem: House Somhairle (Scottish Family) has a 'Main Line' which consists of two members who have never held titles, both deceased, and the 'Secondary Line' which holds titles but are shown as disconnected Kinsman of the family. You can see this when you click on the family crest to view the family tree. At later dates the descendants of Somerled pile up on the left of the tree with no connections showing descent.

Current Family
Main line:
Gilbride Somhairle B. 1 January, 1089, D. 1 January, 1136 - No Titles
- Daughter - Effie Somhairle B. 1 January, 1118, D. 1 January, 1152 - No Titles, no children

Secondary line:
Duke Somerled of Søreyar (Duke and Thanage of Søreyar, Thanage of Argyll
- Wife - Duchess Ragnhild of Søreyar (House of Crovan)
- Sons - Ragnall, Dugald, Angus Mac Somerled

In Vanilla these lines are actually one family. Gilbride is the father of both Effie and Somerled. Effie was also married to Earl Malcolm of Ross (House Mc Aeda) with a daughter (Hvorflaed) and a son (Adam)

This has popped up since the release of the Jade Dragon DLC and is still in the latest Beta of CKII +

Err... okay.
Seems pretty minor to me, but if it's a problem for you we can fix it anyway.
What would really be helpful here would however be the IDs of the characters - in CK2+ they are visible in the tooltip when you hover over a character.

Can you just post the IDs of those characters that need to be edited, and how they should be related? That would make work for me much easier.
Like this (example):
10012647 (Duke Harald) should be father of 10034601 (Countess Rebecca)
If possible also which culture they are of, as characters are sorted like this in the files.

 

[cchiu23]

Try deleting the old version of the mod before installing the new one.
You know, just like it says in the instructions.

There's no such bug and it could only happen by mixing old and new files.

oh woops my bad

I used to delete the old version first but the installer says it removes old files, I guess it doesn't? ¯\_(ツ)_/¯ it should probably should be removed from the installer

edit: I deleted my ck2+ and reinstalled the newest version, its is 100% a glitch, somebody split the latin culture or something and its definitely not on my end

 

[zeress]

oh woops my bad

I used to delete the old version first but the installer says it removes old files, I guess it doesn't? ¯\_(ツ)_/¯ it should probably should be removed from the installer

edit: I deleted my ck2+ and reinstalled the newest version, its is 100% a glitch, somebody split the latin culture or something and its definitely not on my end

Latin culture didn't get split, it got renamed. The fact that you have two latin cultures (unless you mean two in the crusader group) likely there's something wrong on your end, be it using an old save or otherwise. Either way I can't reproduce the issue with latin culture

 

[cchiu23]

Latin culture didn't get split, it got renamed. The fact that you have two latin cultures (unless you mean two in the crusader group) likely there's something wrong on your end, be it using an old save or otherwise. Either way I can't reproduce the issue with latin culture

yes, I mean the two latin cultures INSIDE the crusader group

the first one only has one random first name, the second one only has one random last name




is that intentional? cause I'm hoping to do a prester john inspired play through

 

[tylonator]

Err... okay.
Seems pretty minor to me, but if it's a problem for you we can fix it anyway.
What would really be helpful here would however be the IDs of the characters - in CK2+ they are visible in the tooltip when you hover over a character.

Can you just post the IDs of those characters that need to be edited, and how they should be related? That would make work for me much easier.
Like this (example):
10012647 (Duke Harald) should be father of 10034601 (Countess Rebecca)
If possible also which culture they are of, as characters are sorted like this in the files.

Ya it is minor, I just thought I would mention it since I noticed. Later in the timeline it leads to a really wonky family tree with a ton of side characters on the tree. I guess I'm more curious how this sort of thing happens.

Here is the info you asked for. I hope I formatted it in a way that makes sense.

188870 (Gilbride Somhairle - Scottish) should be the father of 220027 (Duke Somerled of Søreyar - Scottish)
* Recap: 220027 and his descendants should also be descendants of 188870*

188871 (Effie Somhairle - Scottish) – daughter of 188870 (Gilbride Somhairle - Scottish)
- Husband should be 83589 (Count Malcom of Cromarty – Scottish)
- Daughter should be 220038 (Gormelia Mac Bethain – Scottish) who is Hvorflaed Mac Áeda – Scottish in vanilla
* not sure why she is her own house
* Also Hvorflaed (Hvarflod) in real life was the second wife Harald Maddadsson (220020 Duke Harald of Nordeyjar - Norwegian). She is sometimes mistakenly referred to as Gormelia (Gormflaith) in some sources see https://en.wikipedia.org/wiki/Harald_Maddadsson
- Son should be 83590 (Adam Mac Áeda – Scottish)
*Recap: 188871 should be the wife of 83589 and the mother of his descendants (220038 and 83590)*

I really appreciate the exceptional detail that you and your team put into this mod.

 

[zazenzach]

This is weird. I had the Sultanate of Mesopotamia (a Kingdom) randomly become the primary title of the Abbassids when the Arabian Empire (an Empire) still existed. I saved the game and reloaded in as the abbassids. I tried to make the Arabian Empire the primary title again but it wont let you. Did some random chain of events occur or is this a bug?

just to update, the bug fixes itself once you shutdown the game and relaunch it. every so often it messes up again. very weird.

 

[zeress]

yes, I mean the two latin cultures INSIDE the crusader group

the first one only has one random first name, the second one only has one random last name




is that intentional? cause I'm hoping to do a prester john inspired play through

Outremer and Latin are two different cultures with different triggers and features, so yup to intentional. Latin Iirc emerges from Catholics taking over the ERE and Outremer from a melting pot of Crusaders holding land in Jerusalem.

I can't confirm right now for Outremer but Latin works fine for me, lots of different family names.

 

[cchiu23]

Outremer and Latin are two different cultures with different triggers and features, so yup to intentional. Latin Iirc emerges from Catholics taking over the ERE and Outremer from a melting pot of Crusaders holding land in Jerusalem.

I can't confirm right now for Outremer but Latin works fine for me, lots of different family names.

well shit, it turns out that it really was on my side


this beta patch broke cpr+ for some reason, woops

 

[vukica]

* not sure why she is her own house

It seems like original vanilla dynasty design practice was "If unsure, make a fictional house".
And then it continued in the Plus base... So yeah... I've already taken out a few of the fictional houses but there's probaly a lot more of them.

 

[Tmadmad]

all reformed pagan religion religious head titles creation requirement was changed to match reformed norse but some still have the capital requirement.
reformed finnish religious head title have child_of_ukko trait requirement which is impossible to get.

 

[schwarherz]

reformed finnish religious head title have child_of_ukko trait requirement which is impossible to get.

Oh...uh...oops. Pretend you didn't see that.