CK III - Reforming a non-Catholic Christian faith that has Rite before and after does not keep the Pope as Head of Faith

[Pilchowski]

Short summary of your issue
Reforming a non-Catholic Christian faith that has Rite before and after does not keep the Pope as Head of Faith

Game Version
1.6.0

What OS are you playing on?
Windows

What platform are you using?
Steam

What DLC do you have installed?
Royal Court,

Do you have mods enabled?
No

Have you tried verifying your game files (Steam only)?
No

How much "pain" is this causing you?
6

Please explain the issue you experienced in the most condensed way possible
I have been playing Fate of Iberia and wanted to reform the Mozarabic faith to be more equal and tolerant (i.e. islamic syncretism, equal gender law, etc.) but maintain the Catholic Pope by keeping Rite. However, on reforming my faith, I didn't keep the Catholic Pope. Instead, an entire new Pope for the new faith was created, despite Rite saying I'd keep my old faith.

Please explain how to reproduce the issue
Reform a non-Catholic faith with Rite.

Is there anything else you think could help us identify/replicate the issue?
I specifically reformed Mozarabic, and have not chosen either to break away nor bind the faith to Rome. I do not know if the same thing happens with other faiths with Rite

I have attached a save game
Yes

Upload Attachment
File(s) attached

 

[YellowPress]

Pretty sure you can't reform and keep it, like how you can't create a faith with ecumenism, or combine warmonger and Islam

 

[Mcgan]

It's a scope problem:

Spoiler: Bugged code

\common\on_action\religion_on_actions.txt
on_faith_created lines 71-87

        faith = {
            [...]
            ## Faiths with the Rite tenet get to keep their old HoF.
            else_if = {
                limit = {
                    # Assuming they exist.
                    NOT = { faith = scope:old_faith.religious_head.faith }       <----- we're already in the "faith" scope, checking the faith of the faith won't work
                    # & have the appropriate doctrine parameter.
                    has_doctrine_parameter = maintains_head_of_faith_on_creation
                }
                set_religious_head_title = scope:old_faith.religious_head_title
                # Christian faiths also get to keep ecumenism.
                if = {
                    limit = {
                        scope:old_faith = { has_doctrine = special_doctrine_ecumenical_christian }
                    }
                    add_doctrine = special_doctrine_ecumenical_christian
                }
            }

Here's what I use to fix it:

Spoiler: Fixed code

            ## Faiths with the Rite tenet get to keep their old HoF.
            else_if = {
                limit = {
                    # Must have the appropriate doctrine parameter.
                    has_doctrine_parameter = maintains_head_of_faith_on_creation    # this first
                    # Assuming old HoF exist.
                    NOT = { this = scope:old_faith.religious_head.faith }           # right scope
                }
                set_religious_head_title = scope:old_faith.religious_head_title
            }
            if = {            # Make this depend on the correct doctrine parameter
                limit = {
                    # Christian faiths also get to keep ecumenism.
                    religion = religion:christianity_religion
                    has_doctrine_parameter = ecumenical_christians_keep_ecumenism
                    scope:old_faith = { has_doctrine = special_doctrine_ecumenical_christian }
                }
                if = {       # Improve compatibility with mods? Extra safety doesn't hurt anyway
                    limit = { NOT = { has_doctrine = special_doctrine_ecumenical_christian } }
                    add_doctrine = special_doctrine_ecumenical_christian
                }
            }

Edit: Turns out this bug is not the reason the HoF doesn't properly transfer in some cases.
See here:

Need help figuring out rite tenet

So I've created new Norse faith using Rite tenet, but for some reason this faith spawned with new religious head anyway, why?

forum.paradoxplaza.com

 

[Pilchowski]

Pretty sure you can't reform and keep it, like how you can't create a faith with ecumenism, or combine warmonger and Islam

That changed with the most recent release. Christian Faith's keep Ecumenism with the Rite trait, and are meant to keep the Pope as well but don't.

It's a scope problem:

Spoiler: Bugged code

\common\on_action\religion_on_actions.txt
on_faith_created lines 71-87

        faith = {
            [...]
            ## Faiths with the Rite tenet get to keep their old HoF.
            else_if = {
                limit = {
                    # Assuming they exist.
                    NOT = { faith = scope:old_faith.religious_head.faith }       <----- we're already in the "faith" scope, checking the faith of the faith won't work
                    # & have the appropriate doctrine parameter.
                    has_doctrine_parameter = maintains_head_of_faith_on_creation
                }
                set_religious_head_title = scope:old_faith.religious_head_title
                # Christian faiths also get to keep ecumenism.
                if = {
                    limit = {
                        scope:old_faith = { has_doctrine = special_doctrine_ecumenical_christian }
                    }
                    add_doctrine = special_doctrine_ecumenical_christian
                }
            }

Here's what I use to fix it:

Spoiler: Fixed code

            ## Faiths with the Rite tenet get to keep their old HoF.
            else_if = {
                limit = {
                    # Assuming they exist.
                    scope:old_faith = { exists = religious_head }           # making sure the previous faith actually has a head of faith at that point (just in case)
                    NOT = { this = scope:old_faith.religious_head.faith }      # right scope
                    # & have the appropriate doctrine parameter.
                    has_doctrine_parameter = maintains_head_of_faith_on_creation
                }
                set_religious_head_title = scope:old_faith.religious_head_title
            }
            if = {            # Make this depend on the correct doctrine parameter
                limit = {
                    # Christian faiths also get to keep ecumenism.
                    religion = religion:christianity_religion
                    has_doctrine_parameter = ecumenical_christians_keep_ecumenism
                    scope:old_faith = { has_doctrine = special_doctrine_ecumenical_christian }
                }
                if = {       # Improve compatibility with mods? Extra safety doesn't hurt anyway
                    limit = { NOT = { has_doctrine = special_doctrine_ecumenical_christian } }
                    add_doctrine = special_doctrine_ecumenical_christian
                }
            }

Since this is an achievement save, I'll wait until its patched, but thanks for figuring out what the issue is, I'll fix it if a patch doesn't come soon