CK II - 3.0 [PXTU] Decision secretly_convert_to_close_relations_religion has incorrect scope

[Yashichi]

One line summary of your issue
3.0 [PXTU] Decision secretly_convert_to_close_relations_religion has incorrect scope

Game Version
3.0 [PXTU]

What expansions do you have installed?
All of the above

Do you have mods enabled?
No

Please explain your issue is in as much detail as possible.
The targeted decision "secretly_convert_to_close_relations_religion", found in mnm_secret_religious_societies_decisions.txt, is intended to allow characters to secretly convert to the religion of their spouse, consort, or friend. In version 3.0 the decision script was changed to incorporate the trigger "dlc_religion_check_trigger", to verify that the player owns the appropriate DLC to be able to play as the religion they are converting to. However, the trigger is scoped incorrectly, and is checking that the player's religion is playable instead of the spouse/consort/friend. This can lead to an unintended game over.

The decision script currently contains:

AND = {
                    spouse = {
                        character = FROM
                        dlc_religion_check_trigger = yes
                    }
                    NOR = {
                        religion = FROM
                        religion = { target_type = secret target = FROM }
                    }
                }

Since the "spouse" scope refers to the player in this case, the "dlc_religion_check_trigger" is checking the player's religion and not the spouse's. The same issue exists for consorts and friends. It can be fixed by moving the "dlc_religion_check_trigger = yes" line outside of the OR block in the decision potential block.

Steps to reproduce the issue.
1. Disable a religion-unlocking DLC, such as Sword of Islam.

2. Play a ruler of any religion allowed by the remaining DLC, such as a Hindu.

3. Take a spouse or consort of a disallowed religion, such as a Sunni.

4. Right click the spouse. The option to secretly convert to their religion will appear. Take the decision.

5. Your ruler now has a secret religion that is enabled by the missing DLC. Openly converting to the religion causes a game over.

Upload Attachment