CK II - [3.0] [PXTU] Africans cannot create upgraded/alternate fetishes

[jonjowett]

One line summary of your issue
[3.0] [PXTU] Africans cannot create upgraded/alternate fetishes

Game Version
[3.0] [PXTU]

What expansions do you have installed?
All of the above

Do you have mods enabled?
No

Please explain your issue is in as much detail as possible.
This bug is similar to the smithing issues 2 patches ago. (Eg: An awful smithed weapon would block you from smithing a much-nicer one.)

Basically, African pagans with a high rank in their warrior lodge can create fetishes of various levels (at least levels 1-3; not sure if 4 is possible) and focuses (eg. benevolent/malevolent spirit for the mask). However, once you have a mask (or totem) in your inventory, it is impossible to create another one - for example, if you want to replace your level 1 mask with a level 3 one. You have to dispose of your existing one (by destroying it or giving it away) before you can take the decision again.

Just as the smithing restrictions have been lifted, I think it makes sense to lift the restrictions on fetish creation. If the player wants to create multiple fetishes (eg. for a simple upgrade; or to switch masks based on their characters' needs/mood), I think they should be able to do so without having to resort to workarounds.

The culprit code is here (decisions\hf_warrior_lodge_decisions.txt):

	warrior_lodge_west_african_create_fetish = {

#snip

		allow = {

#snip

			custom_tooltip = {
				text = tooltip_has_african_mask_duplicate
   				OR = {
   					NOT = {
   						any_artifact = {
   							has_artifact_flag = mask 
   						}
   					}
   					NOT = {
   						any_artifact = {
   							has_artifact_flag = totem 
   						}
   					}
   				}
   			}
		}

Steps to reproduce the issue.
Start as an African pagan. Join the warrior lodge and level up a few times. Create a level 1 mask and totem. Now try to create a level 3 mask and totem.

Upload Attachment