CK II - [3.0] Dynamic crusader states forming without capturing land

[tywinzo]

One line summary of your issue
[3.0] Dynamic crusader states forming without capturing land

Game Version
3.0

What expansions do you have installed?

Monks & Mystics,
The Reapers Due,
Conclave,
Way of Life,
Charlemagne,
Sons of Abraham,
The Old Gods,
The Republic,
Legacy of Rome,
Holy Fury

Do you have mods enabled?
No

Please explain your issue is in as much detail as possible.
When running regular Crusades as Christian, crusader states form even though they do not control the entire enemy duchy with sieged holdings.

Steps to reproduce the issue.
Randomly run Crusades.

Upload Attachment

 

[CyberSpyder]

I thought I was seeing that, but I wasn't completely sure the land hadn't been captured. Took a gander at the code governing it, and it's pretty unintuitive, though I didn't actually see any problem with it.

This is the part that's supposed to guarantee the duchy is completely controlled, in HFP_crusade_flavor.txt line 176:

NOT = {
    any_direct_de_jure_vassal_title = {
        NOT = {
            FROM = {
                county = {
                    title = PREVPREV
                }
            }
        }
        location = {
            NOT = {
                controlled_by = ROOT
            }
        }
    }
}

It's fired from on_siege_over_winner, where ROOT should be the owner of a winning unit, and the holding captured is FROM; this section is starting under FROM = { location = { duchy = {, so it should be scoped to the de-jure duchy of a just-captured provincial capital. Which means it should be looking at every de-jure county of that duchy and checking if any of them are both not the province just captured (i.e., checking other provinces in the duchy) and controlled by someone other than the winning unit's owner; if any of them are, it shouldn't fire. Except it does seem to be firing. Sometimes.

 

[tywinzo]

Yeah, I read the code too. There is something wrong somewhere. It can happen almost right after a Crusade starts and no armies made it to the holy land yet, yet north east egypt becomes a crusader state suddenly. It's not too hard to reproduce.

 

[CyberSpyder]

You've seen it happen before any troops were even in the area? That's crazy. Suggests a much deeper problem than I was thinking.

 

[Duskwave]

I had German Antioch form during a Crusade for Andalusia. Almost immediately after it started, and I don't think there were other wars (or even armies) in that area either. I think Syria might have been the original Crusade target before I redirected it to Andalusia, which may be relevant, but not certain.

 

[Lewa263]

I saw Antioch form once just as the first Catholic armies reached that area. I guess a county might have been controlled through a quick assault, but certainly most of that duchy was not controlled before the Crusader state appeared.

 

[tywinzo]

Okay, I found the bug now. Indeed the land is given out for no reason.

Paradox: Ping me back if you are interested in the solution.

 

[CyberSpyder]

What, just going to keep the rest of us in suspense?