CK II - [2.8.3.3] [SAHQ] Miscalculated score for sending physician to China

[jonjowett]

One line summary of your issue
[2.8.3.3] [SAHQ] Miscalculated score for sending physician to China

Game Version
[2.8.3.3] [SAHQ]

What expansions do you have installed?
All of the above

Do you have mods enabled?
No

Please explain your issue is in as much detail as possible.
In the attached screenshots, you can see the score calculation for the two physicians who are eligible to be sent to China. They are both slightly incorrect.

---

Mir Sayyid Ali:
- Has +25 for Patient, but does not have the Patient trait
- Does not have +25 for his Diligent trait
- Does not have +50 for Mastermind Theologian



---

Badda:
- Has +25 for Patient, but does not have the Patient trait
- Does not have +25 for Scholarly Theologian



---

My theory on looking at the relevant code is that something is going wrong with the scope for thescoring part of this event. Notice how all of the correctly-evaluated scores have a FROMFROM block, whereas the incorrectly-evaluated scores don't. Logically, I would expect all of the blocks relating to the physician should have the same structure, but they don't. So I'm pointing my finger at this as the probable cause!

Spoiler

        third_party_score = {
            factor = 100
        
            additive_modifier = {
                value = -50
                FROMFROM = {
                    show_scope_change = no
                    NOT = { learning = 8 }
                }
            }
        
            additive_modifier = {
                value = 40
                FROMFROM = {
                    show_scope_change = no
                    learning = 8                
                    hidden_trigger = {
                        NOT = { learning = 12 }
                    }
                }
            }
            additive_modifier = {
                value = 60
                FROMFROM = {
                    show_scope_change = no
                    learning = 12                
                    hidden_trigger = {
                        NOT = { learning = 16 }
                    }
                }
            }
            additive_modifier = {
                value = 100
                FROMFROM = {
                    show_scope_change = no
                    learning = 16            
                    hidden_trigger = {
                        NOT = { learning = 20 }
                    }
                }
            }
            additive_modifier = {
                value = 140
                FROMFROM = {
                    show_scope_change = no
                    learning = 20            
                    hidden_trigger = {
                        NOT = { learning = 24 }
                    }
                }
            }
            additive_modifier = {
                value = 180
                FROMFROM = {
                    show_scope_change = no
                    learning = 24            
                    hidden_trigger = {
                        NOT = { learning = 28 }
                    }
                }
            }
            additive_modifier = {
                value = 220
                FROMFROM = {
                    show_scope_change = no
                    learning = 28            
                    hidden_trigger = {
                        NOT = { learning = 32 }
                    }
                }
            }
            additive_modifier = {
                value = 260
                FROMFROM = {
                    show_scope_change = no
                    learning = 32
                }
            }
            additive_modifier = {
                value = 100
                FROMFROM = {
                    show_scope_change = no
                    trait = genius
                }
            }
            additive_modifier = {
                value = 50
                FROMFROM = {
                    show_scope_change = no
                    trait = quick
                }
            }
            additive_modifier = {
                value = 50
                FROMFROM = {
                    show_scope_change = no
                    trait = shrewd
                }
            }
            additive_modifier = {
                value = 150
                FROMFROM = {
                    show_scope_change = no
                    trait = physician
                }
            }
            additive_modifier = {
                value = 50
                FROMFROM = {
                    show_scope_change = no
                    trait = mystic
                }
            }
            additive_modifier = {
                value = 50
                FROMFROM = {
                    show_scope_change = no
                    trait = scholar
                }
            }
            additive_modifier = {
                value = 25
                trait = scholarly_theologian
            }
            additive_modifier = {
                value = 50
                trait = mastermind_theologian
            }
            additive_modifier = {
                value = 25
                trait = patient
            }
            additive_modifier = {
                value = 25
                trait = diligent
            }
            modifier = {
                factor = 1.5
                FROM = {
                    show_scope_change = no
                    liked_by_offmap = {
                        type = offmap_china
                    }
                }
            }
            modifier = {
                factor = 0.66
                FROM = {
                    show_scope_change = no
                    disliked_by_offmap = {
                        type = offmap_china
                    }
                }
            }
        }

I think that the blocks without FROMFROM are scoping to the protector general, as he is Patient but not Diligent. (My character has neither trait, and the offmap Chinese emperor doesn't have any traits.)



Steps to reproduce the issue.
Load the attached save and choose the option to send a physician to China. Notice that the score calculations are incorrect.

Upload Attachment