CK II - [2.8.3.3] [SAHQ] Chinese weapons have combat_weapon flag, blocking "Search for Smith"

[jonjowett]

One line summary of your issue
[2.8.3.3] [SAHQ] Chinese weapons have combat_weapon flag, blocking "Search for Smith"

Game Version
[2.8.3.3] [SAHQ]

What expansions do you have installed?
All of the above

Do you have mods enabled?
No

Please explain your issue is in as much detail as possible.
All Chinese weapons (with the exception of the Jian) have the "combat_weapon" artifact flag. This means that they block the "Search for a Smith" decision because they count as "weapons forged by a smith". This is counterintuitive because these weapons cannot be smithed - they have to be bought/found/stolen/looted from China.

(It would also be nice if the "Search for Smith" decision was unlocked if you could theoretically obtain higher-tier items than you already own - but I think this has already been mentioned in a dev diary.)

Here's the relevant decision (in ...\decisions\mnm_society_decisions.txt; relevant line marked with a comment):

Spoiler

decisions = {
    employ_a_smith = {
        only_playable = yes
        ai_check_interval = 12
        potential = {
            OR = {
                has_dlc = "Mystics"
                has_dlc = "Jade Dragon"
            }
            OR = {
                mercenary = no
                ai = no
            }
            age = 16
            is_incapable = no
            OR = {
                ai = no
                higher_tier_than = COUNT
            }
            is_landed = yes
            is_lowborn = no
        }
        allow = {
            hidden_trigger = {
                OR = {
                    ai = no
                    wealth = 500
                }
            }
            is_inaccessible_trigger = no
            OR = {
                AND = {
                    custom_tooltip = {
                        text = employ_a_smith_no_weapons_tt
############## This is the problem line ############
                        NOT = { any_artifact = { has_artifact_flag = combat_weapon } } 
############## End of problem line ############
                    }
                    custom_tooltip = {
                        text = has_marshal_tt
                        hidden_tooltip = {
                            job_marshal = { always = yes }
                        }
                    }
                }
                AND = {
                    custom_tooltip = {
                        text = employ_a_smith_no_armor_tt
                        NOT = { any_artifact = { has_artifact_flag = armor_set } }
                    }
                    custom_tooltip = {
                        text = has_marshal_tt
                        hidden_tooltip = {
                            job_marshal = { always = yes }
                        }
                    }
                }
                custom_tooltip = {
                    text = employ_a_smith_no_crowns_tt
                    NOT = { any_artifact = { has_artifact_flag = crown_jewel } }
                }
            }
            custom_tooltip = {
                text = employ_a_smith_cooldown_tt
                hidden_trigger = {
                    NOT = {
                        has_character_modifier = employ_a_smith_cd
                    }
                }
            }
        }
        effect = {
            custom_tooltip = {
                text = employ_a_smith_tt
                hidden_effect = {
                    character_event = { id = MNM.9130 }
                    add_character_modifier = {
                        name = employ_a_smith_cd
                        hidden = yes
                        years = 2
                    }
                }
            }
        }
        revoke_allowed = {
            always = no
        }
        ai_will_do = {
            factor = 1
            modifier = {
                factor = 0.5
                NOR = {
                    tier = KING
                    tier = EMPEROR
                }
            }
            modifier = {
                factor = 0.5
                trait = greedy
            }
            modifier = {
                factor = 2
                trait = ambitious
            }
            modifier = {
                factor = 0.1
                trait = content
            }
        }
    }
}

And here's the code for the various Chinese weapons (from ...\common\artifacts\00_artifacts.txt ; note that they all have the combat_weapon flag, with the exception of the Jian):

Spoiler

chinese_serpent_spear = {
    monthly_character_prestige = 0.4
    martial = 2
    combat_rating = 1
    command_modifier = {
        cavalry = 0.025
        heavy_infantry = 0.025
    }
    quality = 2
    active = {
        is_adult = yes
    }
    flags = { chinese combat_weapon lance }
    stacking = no
    picture = "GFX_serpent_spear"
    slot = weapon
}
chinese_ji = {
    monthly_character_prestige = 0.65
    martial = 3
    combat_rating = 1
    command_modifier = {
        cavalry = 0.05
        heavy_infantry = 0.05
    }
    quality = 3
    active = {
        is_adult = yes
    }
    flags = { chinese combat_weapon lance }
    stacking = no
    picture = "GFX_ji"
    slot = weapon
}
chinese_crossbow = {
    monthly_character_prestige = 0.25
    martial = 2
    combat_rating = 1
    defensive_plot_power_modifier = 0.15
    command_modifier = {
        light_infantry = 0.10
    }
    quality = 3
    active = {
        is_adult = yes
    }
    flags = { chinese combat_weapon crossbow ranged_weapon }
    stacking = no
    picture = "GFX_relic_box_simple"
    slot = weapon
}



jian_sword = {
    quality = 4
    monthly_character_prestige = 1
    martial = 3
    combat_rating = 3
    active = {
        is_adult = yes
    }
    flags = { chinese sword }
    stacking = no
    picture = "GFX_jian_sword"
    slot = weapon
}

I can see three possible resolutions:

1. Change the localisation text to make it clear that all weapons block the event - not just smithed weapons. This is not ideal IMO because bad Chinese weapons (like the Ji) would block emperors from making the far-superior tier-3 and tier-4 weapons.

2. If combat_weapon is only used for the smith event, you can safely remove the combat_weapon flag from the affected Chinese weapons.

3. If combat_weapon is used elsewhere, you should probably add it to the Jian. Then, to fix this issue, you could change it so that only non-Chinese weapons block "Search for Smith". Something like this:

                    custom_tooltip = {
                        text = employ_a_smith_no_weapons_tt
                        NOT = {
                            any_artifact = {
                                AND = {
                                    has_artifact_flag = combat_weapon
                                    NOT = { has_artifact_flag = chinese }
                                }
                            }
                        }
                    }

Or this:

                    custom_tooltip = {
                        text = employ_a_smith_no_weapons_tt
                        NOT = {
                            any_artifact = {
                                AND = {
                                    has_artifact_flag = combat_weapon
                                    has_artifact_flag = created
                                }
                            }
                        }
                    }

Steps to reproduce the issue.
Start a new game.
Ensure your treasury is empty.
Add one of the affected Chinese weapons to your treasury using the console.
Observe that the "Search for a Smith" decision is now blocked.

Upload Attachment