Calling all scripting gurus

unmerged(6777) · Apr 13, 2005

I can't for the life of me figure out why, but this event is the one that is responsible for the CTDs that will occur immediatley after the Horde appears or after you load the 1337 scenario (where the Hordes exist).

Can anyone else figure out why?

Code:

###################################
# Horde raids into adjacent lands #
###################################

province_x_province_event = { #The Golden Horde has raided one of our border provinces!

	id = 5520
	picture = "event_battle"

	trigger = {
		condition = { type = exists value = GOLD }
		condition = { type = to
			condition = { type = not value = { type = has_province_effect value = { looted = yes } } }
		}
		condition = { type = from
			condition = { type = owner
				condition = { type = title value = GOLD }
			}
		}
		condition = { type = to
			condition = {
				type = or
				condition = {
					type = not
					value = { type = owner
						condition = { type = title value = GOLD }
					}
				}
				condition = {
					type = not
					value = { type = owner
						condition = { type = realm_ruler
							condition = { type = not value = { type = title value = GOLD }}
						}
					}
				}
			}
		}
	}

	mean_time_to_happen = {
		months = 120

		modifier = {
			condition = { type = to
				condition = { type = regiment_mobilized }
			}
			factor = 2
		}
		modifier = {
			condition = { type = from
				condition = { type = regiment_mobilized }
			}
			factor = 5
		}
		modifier = {
			condition = { type = to
				condition = { type = not value = { type = ruler_martial value = 3 } }
			}
			factor = 0.75
		}
		modifier = {
			condition = { type = to
				condition = { type = not value = { type = ruler_martial value = 5 } }
			}
			factor = 0.75
		}
		modifier = {
			condition = { type = to
				condition = { type = ruler_martial value = 8 }
			}
			factor = 1.5
		}
		modifier = {
			condition = { type = to
				condition = { type = ruler_martial value = 11 }
			}
			factor = 1.5
		}
		modifier = {
			condition = { type = to
				condition = { type = ruler_martial value = 14 }
			}
			factor = 1.5
		}
		modifier = {
			condition = { type = from
				condition = { type = not value = { type = ruler_martial value = 3 } }
			}
			factor = 1.5
		}
		modifier = {
			condition = { type = from
				condition = { type = not value = { type = ruler_martial value = 5 } }
			}
			factor = 1.5
		}
		modifier = {
			condition = { type = from
				condition = { type = ruler_martial value = 8 }
			}
			factor = 0.75
		}
		modifier = {
			condition = { type = from
				condition = { type = ruler_martial value = 11 }
			}
			factor = 0.75
		}
		modifier = {
			condition = { type = from
				condition = { type = ruler_martial value = 14 }
			}
			factor = 0.75
		}
		modifier = {
			condition = { type = from
				condition = { type = owner
					condition = { type = atwar }
				}
			}
			factor = 0.66
		}
		modifier = {
			condition = { type = to
				condition = { type = owner
					condition = { type = atwar }
				}
			}
			factor = 2
		}
		modifier = {
			condition = { type = difficulty value = 1 }
			factor = 0.8
		}
		modifier = {
			condition = { type = difficulty value = 2 }
			factor = 0.8
		}
		modifier = {
			condition = { type = difficulty value = 3 }
			factor = 0.8
		}
		modifier = {
			condition = { type = difficulty value = 4 }
			factor = 0.8
		}
	}

	action_a = { #Curses!
		effect = { type = to effect = { type = prosperity value = -1 }}
		effect = { type = to effect = { type = ruler_gold scale = -0.5 }}
		effect = { type = to
			effect = { type = random chance = 33
				effect = { type = add_province_effect value = looted }
			}
		}
	}
}

richvh · Apr 13, 2005

MrT said:
Code:

effect = { type = to effect = { type = prosperity value = -1 }}

What happens when this is applied to a province that is poor? This is the only thing I see. Try adding a trigger condition of

Code:

condition = { type = not
  value = { type = to
    condition = { type = has_province_effect value = { poor = yes } }
  }
}

and see if that fixes it.

unmerged(6777) · Apr 13, 2005

richvh said:
What happens when this is applied to a province that is poor? This is the only thing I see. Try adding a trigger condition of

Code:

condition = { type = not value = { type = to condition = { type = has_province_effect value = { poor = yes } } } }

and see if that fixes it.

Nope. I tried removing the effect completely and it still crashes within a week or so. I also tried removing the random chance component and that doesn't stop the crashes either.

The Regent · Apr 13, 2005

Maybe try this for your trigger:

Code:

trigger = {
		condition = { type = exists value = GOLD }
		condition = { type = to
			condition = { type = not value = { type = has_province_effect value = { looted = yes } } }
		}
		condition = { type = from
			condition = { type = realm_ruler
				condition = { type = title value = GOLD }
			}
		}
		condition = { type = to
			condition = {
				type = or
				condition = {
					type = not
					value = { type = realm_ruler
						condition = { type = title value = GOLD }
					}
				}
				condition = {
					type = not
					value = { type = realm_ruler
						condition = { type = not value = { type = title value = GOLD }}
					}
				}
			}
		}
	}

If that doesn't work, look at your last trigger combo with the OR. It looks like it says, NOT the owner of GOLD OR NOT the owner of NOT GOLD. Are my strained eyes right?

richvh · Apr 13, 2005

realm_ruler is a character condition; you have to do a context shift to owner before using it in a province event, so that's not it. However, I think you spotted it with the extra NOT.

unmerged(6777) · Apr 13, 2005

Just to prove that every day you learn something new....

So I decided to be disgustingly methodical so I disabled all game events except for this one:

Code:

province_x_province_event = { #The Golden Horde has raided one of our border provinces!

	id = 5520
	picture = "event_battle"

	trigger = {
		condition = { type = exists value = GOLD }
	}

	mean_time_to_happen = {
		days = 1

	}

	action_a = { #Curses!
	}
}

Remember waaaaaaaaaaaaaaaaaay back when I suggested that you should never use an mtth of 1 day because it could produce unexpected results? Well....

Interestingly, when I loaded as 2-province Byzantium in 1337 (where GOLD exists) the event ran nicely but only triggered once per year for five consecutive years. Now if this was an empirical trigger you'd expect the event to fire roughly 720 times per year. Considering that I ran it long enough where you'd expect an average of about 3600 firings of this event, you'd think that only 5 instances was a little odd.

Me too.

Oh...and I will now resume my methodical testing to isolate the error. Just thought you all might be interested in this little tidbit.

unmerged(6777) · Apr 13, 2005

More fun and FYI stuff...

Code:

province_x_province_event = { #The Golden Horde has raided one of our border provinces!

	id = 5520
	picture = "event_battle"

	trigger = {
		condition = { type = exists value = GOLD }
	}

	mean_time_to_happen = {
		days = 1

	}

	action_a = { #Curses!
		effect = { type = to effect = { type = prosperity value = -1 }}
	}
}

This does not crash - even when the prosperity of a province is at minimum and is pushed down again by the event (essentially the event effect is ignored).

Testing resumes...

richvh · Apr 13, 2005

Take a look at that double NOT in the realm_ruler condition that The Regent spotted. That's definitely wrong, whether or not it causes the crash.

unmerged(6777) · Apr 13, 2005

Yep...I realised that as well but I figured I'd be super-methodical and test everything I could before I test the triggers.

Code:

province_x_province_event = { #The Golden Horde has raided one of our border provinces!

	id = 5520
	picture = "event_battle"

	trigger = {
		condition = { type = exists value = GOLD }
	}

	mean_time_to_happen = {
		days = 1

	}

	action_a = { #Curses!
		effect = { type = to effect = { type = prosperity value = -1 }}
		effect = { type = to effect = { type = ruler_gold scale = -0.5 }}
		effect = { type = to
			effect = { type = random chance = 33
				effect = { type = add_province_effect value = looted }
			}
		}
	}
}

The above triggers perfectly and all of the event effects work perfectly (inculding the random chance one).

Now to add the mtth modifier block back in and see what happens.

unmerged(6777) · Apr 13, 2005

Okay...further testing now confirms that all event effects work and that none of the modifiers causes a crash either. That leave us with the trigger.

Strangely, the following event works perfectly and I would ahve sworn that I tested this 2 hours ago and it crashed.

Code:

###################################
# Horde raids into adjacent lands #
###################################

province_x_province_event = { #The Golden Horde has raided one of our border provinces!

	id = 5520
	picture = "event_battle"

	trigger = {
		condition = { type = exists value = GOLD }
		condition = { type = to
			condition = { type = not value = { type = has_province_effect value = { looted = yes } } }
		}
		condition = { type = from
			condition = { type = owner
				condition = { type = realm_ruler
					condition = { type = title value = GOLD }
				}
			}
		}
		condition = { type = to
			condition = { type = owner
				condition = { type = realm_ruler
					condition = { type = not value = { type = title value = GOLD }}
				}
			}
		}
	}

	mean_time_to_happen = {
		months = 120

		modifier = {
			condition = { type = to
				condition = { type = regiment_mobilized }
			}
			factor = 2
		}
		modifier = {
			condition = { type = from
				condition = { type = regiment_mobilized }
			}
			factor = 5
		}
		modifier = {
			condition = { type = to
				condition = { type = not value = { type = ruler_martial value = 3 } }
			}
			factor = 0.75
		}
		modifier = {
			condition = { type = to
				condition = { type = not value = { type = ruler_martial value = 5 } }
			}
			factor = 0.75
		}
		modifier = {
			condition = { type = to
				condition = { type = ruler_martial value = 8 }
			}
			factor = 1.5
		}
		modifier = {
			condition = { type = to
				condition = { type = ruler_martial value = 11 }
			}
			factor = 1.5
		}
		modifier = {
			condition = { type = to
				condition = { type = ruler_martial value = 14 }
			}
			factor = 1.5
		}
		modifier = {
			condition = { type = from
				condition = { type = not value = { type = ruler_martial value = 3 } }
			}
			factor = 1.5
		}
		modifier = {
			condition = { type = from
				condition = { type = not value = { type = ruler_martial value = 5 } }
			}
			factor = 1.5
		}
		modifier = {
			condition = { type = from
				condition = { type = ruler_martial value = 8 }
			}
			factor = 0.75
		}
		modifier = {
			condition = { type = from
				condition = { type = ruler_martial value = 11 }
			}
			factor = 0.75
		}
		modifier = {
			condition = { type = from
				condition = { type = ruler_martial value = 14 }
			}
			factor = 0.75
		}
		modifier = {
			condition = { type = from
				condition = { type = owner
					condition = { type = atwar }
				}
			}
			factor = 0.66
		}
		modifier = {
			condition = { type = to
				condition = { type = owner
					condition = { type = atwar }
				}
			}
			factor = 2
		}
		modifier = {
			condition = { type = difficulty value = 1 }
			factor = 0.8
		}
		modifier = {
			condition = { type = difficulty value = 2 }
			factor = 0.8
		}
		modifier = {
			condition = { type = difficulty value = 3 }
			factor = 0.8
		}
		modifier = {
			condition = { type = difficulty value = 4 }
			factor = 0.8
		}
	}

	action_a = { #Curses!
		effect = { type = to effect = { type = prosperity value = -1 }}
		effect = { type = to effect = { type = ruler_gold scale = -0.5 }}
		effect = { type = to
			effect = { type = random chance = 33
				effect = { type = add_province_effect value = looted }
			}
		}
	}
}

unmerged(6777) · Apr 13, 2005

AAAAAAAAAAARRRRRRRRRRRRRRRRRGGGGGGGGGGGGGGGGGHHHHHHHHHHHHHHHH

Now copying the identical event back to the file, updating the id to 5521 and substituting ILKH for GOLD, I now get rapid CTD.

unmerged(2456) · Apr 13, 2005

you are using character and province csc conditions in the triggers.

For province events there is only controller and owner that work.

unmerged(21937) · Apr 13, 2005

If you first CSC to owner or controller, you can use character conditions and character CSCs as usual.

unmerged(6777) · Apr 13, 2005

Gaaaaaaaa

Byak and I have been working on this bloody thing for the past...er...<*checks watch*>.....10+ hours and are still no closer to understanding why it crashes. I have tested every single trigger aspect and even done a bunch of extra checks...all to no avail. For some reason this event will crash -- but only sometimes. Sometimes it fires perfectly.

*sob*

So here's the latest very simple rendition for people to have a look at while we get some shut-eye. We *know* that the event effects all work perfectly without crashing and we're 99.9999999999% positive that the portion of the trigger that is resulting in a crash is the part I've outlined in green. All of the individual parts of the "from" check seem to work perfectly except - possibly for the bold part (which seems to work intermittently when tested in isolation.

Code:

	id = 5520
	picture = "event_battle"

	trigger = {
		condition = { type = exists value = GOLD }
		condition = { type = to
			condition = { type = not value = { type = has_province_effect value = { looted = yes } } }
		}
[color=limegreen]		condition = { type = from
			condition = { type = or
				condition = { type = demesne value = GOLD }
				condition = { type = and
					condition = { type = owner
						condition = { type = is_vassal }
					}
					[b]condition = { type = owner
						condition = { type = realm_ruler
							condition = { type = title value = GOLD }
						}
					}[/b]
				}
			}
		}[/color]
		condition = { type = to
			condition = { type = not value = { type = demesne value = GOLD }}
		}
		condition = { type = to
			condition = { type = owner
				condition = { type = realm_ruler
					condition = { type = not value = { type = title value = GOLD }}
				}
			}
		}
	}

	mean_time_to_happen = {
		days = 10

	}

	action_a = { #Curses!
		effect = { type = to effect = { type = prosperity value = -1 }}
		effect = { type = to effect = { type = ruler_gold scale = -0.5 }}
		effect = { type = to
			effect = { type = random chance = 33
				effect = { type = add_province_effect value = looted }
			}
		}
	}
}

But for now...bed time.

The Regent · Apr 13, 2005

MrT said:

Code:

[color=limegreen]		condition = { type = from
			condition = { type = or
				condition = { type = demesne value = GOLD }
				condition = { type = and
	[/color][color=cyan]				condition = { type = owner
						condition = { type = is_vassal }
					}[/color][color=limegreen]
					condition = { type = owner
						condition = { type = realm_ruler
							condition = { type = title value = GOLD }
						}
					}
				}
			}
		}[/color]

Maybe take out the blue bit? Wouldn't the part after it still jump to the top level ruler?

Any other ideas I have, you've probably tried already and the rest are just plain out there. :wacko:

unmerged(6777) · Apr 13, 2005

The Regent said:
Maybe take out the blue bit? Wouldn't the part after it still jump to the top level ruler?

Any other ideas I have, you've probably tried already and the rest are just plain out there. :wacko:

Sadly, I only added the blue bit after it had already crashed without it (my hypothesis being that the crash might be caused by an independent ruler trying to switch to a realm_ruler which, of course, he doesn't have).

Darn but that's annoying.

unmerged(6777) · Apr 13, 2005

Mystery solved.

We discovered a very odd little error in the exe relating to spread events. Johan has fixed it and now my events will run properly again....and the same little anomaly *might* be the source of at least one other crash bug and maybe even a VFC or two.

So it turns out that the time spent on this wasn't a complete waste after all.

unmerged(2456) · Apr 13, 2005

could not you just drop the demense condition since the demesne would fall into being part of the territory under the realm_ruler?

unmerged(6777) · Apr 13, 2005

Yeah...now that the source has been discovered as being an exe issue I'm reverting back to an earlier rewrite version that doesn't have the unneccessary trigger checks in it anymore (more CPU efficient).

Search

Calling all scripting gurus

unmerged(6777)

Field Marshal

richvh

Preserver of the Light

unmerged(6777)

Field Marshal

The Regent

Captain

richvh

Preserver of the Light

unmerged(6777)

Field Marshal

unmerged(6777)

Field Marshal

richvh

Preserver of the Light

unmerged(6777)

Field Marshal

unmerged(6777)

Field Marshal

unmerged(6777)

Field Marshal

unmerged(2456)

Pure Evil Genius

unmerged(21937)

Your Industrial Friend

unmerged(6777)

Field Marshal

The Regent

Captain

unmerged(6777)

Field Marshal

unmerged(6777)

Field Marshal

unmerged(2456)

Pure Evil Genius

unmerged(6777)

Field Marshal