Yeah I read the code (even though I'm not good at that), but I'm still confused because if you read the wording of the achievement, it says "As Communist Bulgaria, form the United Balkan Federation and OWN all Balkan States as cores".
And when you form the Balkan Federation, you get cores in places such as Istria, Zara and Dodecanese, but then you read the wiki and it says the requirements are:
- Current ruling party is Communist
- Is faction leader
- Has completed the focus "The Unification of the Balkans"
- Owns the core states of Romania, Greece, Yugoslavia, and Albania as core states
And then in the notes it says "While achievement toolbox doesn't mention it, but you need turkish territories in Balkans for it to trigger"
So with this information, you would think that you need to OWN (not control) all the states you get cores on, which includes Istria, Zara and Dodecanese
But then, as you point out, if you read the code, it says, for both achievements "is_controlled_by = BUL" and maybe it is because, as I said, I'm not good at reading code, but I see no mention in any of the 2 to not having to own nor control Dodecanese. If it was listed as an exception somehow, I could check if they also include Zara and Istria as exceptions, but I can't see anything like that.
This is why I'm confused, I have 3 places to look into the exact requirements, and all 3 seem to contradict each other, which is why I came with my 3 initial questions:
- Do you need to own the territories or just control them?
- Do these territories include Istria and Zara?
- Are Edirne and Istanbul included?
My main problem is that, since I already got these achievements several months ago, I don't exactly remember when they triggered, and now I want to create a proper guide for others but I'm having trouble explaining the exact requirements (which would alter the strategy significantly, is very different to gain control of a state than having to defeat an entire faction to get them in a peace deal).
Thanks for your help in advance, especially if one of the devs is kind enough to be clear about this for once.