AI 'handicap' on border forts goes too far.

[DanubianCossak]

Hey thanks for the feedback!

All of the base factors were adjusted in my mod because the game does wonky things with fractional factor, and I found it to perform better when there is a larger integer spread between buildings. So they are all still balanced against each other, just with a higher initial value.

AFAIK most of the coding requires you to do that sort of nonsense like "Not = { is_capital = yes }", and I don't know why. I just used the modding subforums list of scopes/triggers etc, and saw things like this:

Are you sure this:

       modifier = {
            factor = 1.05
            allowed_num_of_buildings = 4
        }

is proper code?

Ive never seen this used before and its not on the list of triggers in that modding section thread.

(just thinking out loud maybe this is causing the error you got)

 

[Arumba]

Are you sure this:

       modifier = {
            factor = 1.05
            allowed_num_of_buildings = 4
        }

is proper code?

Ive never seen this used before and its not on the list of triggers in that modding section thread.

(just thinking out loud maybe this is causing the error you got)

Hmm, maybe. It's in there, but its in the modifier section not in the trigger section. Perhaps that's whats causing the problem. Will test.
I believe this is what is used by the university to increase the number of slots available, so its possible I'm using it wrong.

 

[Praetorian44]

Hmm, maybe. It's in there, but its in the modifier section not in the trigger section. Perhaps that's whats causing the problem. Will test.
I believe this is what is used by the university to increase the number of slots available, so its possible I'm using it wrong.

Correct, it is a modifier and not a trigger. You're looking for the following trigger
num_free_building_slots = 1

 

[DanubianCossak]

Hmm, maybe. It's in there, but its in the modifier section not in the trigger section. Perhaps that's whats causing the problem. Will test.
I believe this is what is used by the university to increase the number of slots available, so its possible I'm using it wrong.

Yeah ive spent unjohanly amount of time coding stuff over the years, and this just popped up when you said something was crashing Maybe its not it, but still, looks like bad code to me.

 

[Arumba]

Well that wasn't the issue. I updated the mod to use purely num_free_building_slots but it's still getting this crash: https://support.microsoft.com/en-us/kb/125749

I'm guessing it's no bueno to do that nested any_neighbor_province check

 

[DanubianCossak]

Well that wasn't the issue. I updated the mod to use purely num_free_building_slots but it's still getting this crash: https://support.microsoft.com/en-us/kb/125749

I'm guessing it's no bueno to do that nested any_neighbor_province check

If you upload the buildings file i can take a look / run it via debug exe.

 

[Arumba]

This is my working file, I have a backup that functions before I made some recent changes, so I'll try to compare it to that one for now. Can you link me to a functional eu4 validator? I can't seem to find one. The one that shows up on google is for eu3 and ck2.

 

[Arumba]

Well this is what happens when I obsess over a problem for ~12 hours in the past 24. I somewhere along the line started doing things like this:

AND  {
                island = yes
                NOT = { is_capital = yes }
           }

Instead of this:

AND  = {
                island = yes
                NOT = { is_capital = yes }
             }

I don't know why my brain decided the equals sign wasn't necessary anymore. Derp.

 

[DanubianCossak]

Well this is what happens when I obsess over a problem for ~12 hours in the past 24. I somewhere along the line started doing things like this:

AND  {
                island = yes
                NOT = { is_capital = yes }
           }

Instead of this:

AND  = {
                island = yes
                NOT = { is_capital = yes }
             }

I don't know why my brain decided the equals sign wasn't necessary anymore. Derp.

Yup, after i put your file into my mod, everything loads, but 3 buildings appear be broken (they show all messed up) which happens when you physically break the code (by forgetting = for example).

Couple of things however:

1.) trade_value is a modifier not a trigger; this might be confusing because you are adding AI "modifiers", but those "modifiers" are "trigger" stuff from that modding thread; the "modifier" part from the modding thread is the effect part of decision/event/whatever code.

2.) you have couple of modifiers for navy/army %, you put those in a wrong scope, building file is province scope so if you want to check army/navy size % you need to put the owner = {} thingie.

 

[Arumba]

Yup, after i put your file into my mod, everything loads, but 3 buildings appear be broken (they show all messed up) which happens when you physically break the code (by forgetting = for example).

Couple of things however:

1.) trade_value is a modifier not a trigger; this might be confusing because you are adding AI "modifiers", but those "modifiers" are "trigger" stuff from that modding thread; the "modifier" part from the modding thread is the effect part of decision/event/whatever code.

2.) you have couple of modifiers for navy/army %, you put those in a wrong scope, building file is province scope so if you want to check army/navy size % you need to put the owner = {} thingie.

That probably explains why trying to adjust the AI's preferences on workshops and referencing trade_value wasn't working. Is there a way to pull the trade value from a province? Like Trade good X goods produced = annual trade value. Since the value of trade goods changes over time it makes more sense to me to reference the actual income and not base_production.

I understand the second you part you said, that I did it wrong, but I don't understand how to fix it. Can you give me an example?

Oh, and I fixed the three big mistakes, somehow when I was updating the 16th, 17th, and 18th forts I copied the whole 15th fort into them instead of just the ai_will_do section. I blame fatigue.

 

[DanubianCossak]

That probably explains why trying to adjust the AI's preferences on workshops and referencing trade_value wasn't working. Is there a way to pull the trade value from a province? Like Trade good X goods produced = annual trade value. Since the value of trade goods changes over time it makes more sense to me to reference the actual income and not base_production.

Nope, there is no way to check for dynamic (modified) value. You can reference to trade good (which is what i do in my mod where trade goods start at way different values), or other stuff such as total trade value (which isnt perfect either), or local production etc.

I understand the second you part you said, that I did it wrong, but I don't understand how to fix it. Can you give me an example?

Oh, and I fixed the three big mistakes, somehow when I was updating the 16th, 17th, and 18th forts I copied the whole 15th fort into them instead of just the ai_will_do section. I blame fatigue.

This is what you have:

modifier = {
army_size_percentage = 90
factor = 1.10
}

army_size_percentage = is a country scope trigger, place where you put it is province scope, so you need to change scope; this is what you want:

modifier = {
factor = 1.10
owner = { army_size_percentage = 90 }
}

Do the same thing for all other instances of army_size_percentage and navy_size_percentage.

If you need further assistance you can add me via skype or something, might go faster