Right now the Consumerist Sayyid and Investor traits are loosely restricted to Consumerist characters. If they convert, they will lose the trait (but it might take a reload for that to happen). It's not the best solution, but it could introduce other problems to use the orthodox_opinion modifier (or some other hard-coded, religion-specific opinion modifier).Have you guys considered adjusting the modified Sayyid and Mirza traits that the descendents of Consumerist prophets get to use one of the specific religion opinion flags, like orthodox_opinion? All you would need to do is take one of the opinion flags that the trait file can read, and change all mentions of consumerist in the script files to that flag's religion. Then, localize that religion entry as Consumerist.
This would prevent Americanist descendents of the Consumerist Prophet from getting an opinion boost with other Americanists, and ensure that they get the proper bonus with Consumerists even if they convert.
The reason I suggest orthodox_opinion is the lack of Orthodox on the map, and that it seems unlikely that it would be added.
In a perfect world, we'd get Paradox to allow modders to create their own opinion_customreligion modifiers. I'd also like to be able to create custom sympathy_customreligion traits, but they also rely on specific hard-coded religions.
At least the traits have a more appropriate appearance now, keeping the style and color palette of the old ones but changing the Arabic lettering to a dollar sign.