(4d15) Trade deal screen bugs on close/reopen

[romothecus]

summary: proposed trade deals bug out if the diplomacy screen is closed and then the trade deal is reopened.

reproduce:

1. open diplomacy screen with an AI player

2. create a trade deal with an AI, where the AI will not accept the trade deal. but don't send the deal. instead, close the diplomacy screen. (typical user behavior on observing that the AI will not accept the deal.)

3. re-open the diplomacy screen with the AI player, and try to propose a trade deal again. the deal screen will already be populated with some terms of the old deal.

4. the AI may seem ready to accept the deal it previously would not have. send the deal.

5. observe that the deal implemented does not actually match the deal that the user saw when clicking send.

bug: the user gets a deal that does not match the deal that was displayed on the screen

If this is unclear i'll try to update with screenshots later.

 

[TheDellingr]

not only AI, Humans aswell

we have a 4 Player and a 6 Player game with this bug between players...

hotfix: clean the trade screen bevor you actual trade

 

[Kavonde]

This has also been occuring for me, sometimes even with civs I hadn't previously traded with.

 

[Eitre]

Suffered the same issue, OP gives a good explanation.

 

[DropTheWubz]

Oh yea, it happens to me every single time. Whenever I open trade window regardless with which empire I already have some options set (they are blank options and actually don't happen as I can chose them again if I reopen screen). It's just super annoying you have to clear it out every time before making a deal.