[2.4.2] "has_lover" trigger in wrong scope in event 71004

[richvh]

Event 71004 uses has_lover = no as a trigger in the ROOT scope; however, this event has nothing to do with lovers for the ruler the event is fired for. Instead, this trigger should be used in the any_courtier scope to limit the potential courtiers being seduced by the hedge knight.

This event also has the potential to select different women in each of the two options. The random_courtier selection should be moved to an immediate and saved as an event target.

Since the seducing hedge knight is created for both options, that task could also be moved to the immediate and saved as an event target.

My rewrite of the event:

character_event = {
   id = 71004
   desc = EVTDESC71004   
   
   only_playable = yes
   prisoner = no
   has_character_flag = hedge_knights_visiting
   
   picture = GFX_evt_lovers
   
   trigger = {
     NOT = {   has_character_flag = hedge_knight_recruited }
     NOT = {   has_character_flag = hedge_knight_woman_seduced   }
     any_courtier = {
       has_lover = no
         age = 16
         not = { age = 20 }
         is_female = yes   
         is_married = no
         is_pregnant = no
       has_lover = no
       NOT = { trait = homosexual }
       fertility = 0.1
       culture_group = ROOT
       }       
   }   
   
   immediate = {
     set_character_flag = hedge_knight_woman_seduced
     random_courtier = {
       limit = {
         has_lover = no
         age = 16
         not = { age = 20 }
         is_female = yes   
         is_married = no
         is_pregnant = no
         has_lover = no
         NOT = { trait = homosexual }
         fertility = 0.1
         culture_group = ROOT
       }
       save_event_target_as = seduced_woman
     }
     create_character = {
       random_traits = yes
       dynasty = none
       culture = root
       fertility = 0.6
       female = no
       age = 24
       }
     new_character = {
       save_event_target_as = hedge_knight
     }
   }

   mean_time_to_happen = {
     days = 20
     
     modifier = {
       factor = 5
       has_character_flag = hedge_knight_recruited   
     }     
   }   
   option = {
     name = EVTOPTA71004 #stay
     
     
     event_target:seduced_woman = {
         add_trait = lustful
         event_target:hedge_knight = {
           impregnate = PREV
           add_lover = PREV
         PREV = {
           add_character_modifier = {
             name = "new_love"
             duration = 90
             hidden = yes
           }
         }
         add_character_modifier = {
           name = "new_love"
           duration = 90
           hidden = yes
         }
         add_trait = lustful       
         }
       }
       piety = -10
   }
   option = {
     name = EVTOPTB71004 #dungeon
     ai_chance = {
       factor = 1
       modifier = {
         factor = 100
         OR = {
           trait = cruel
           trait = zealous
          }
       }
     }
     event_target:seduced_woman = {
         add_trait = lustful
       event_target:hedge_knight = {
           impregnate = PREV
           add_lover = PREV
         PREV = {
           add_character_modifier = {
             name = "new_love"
             duration = 90
             hidden = yes
           }
         }
         add_character_modifier = {
           name = "new_love"
           duration = 90
           hidden = yes
         }
         add_trait = lustful
         imprison = ROOT
         }
       }     
   }
}

 

[rageair]

Added to the internal database.

Thank you!