[2.4.2] Bad scoping in pagan_subjugation CB

[richvh]

In the on_success section of the pagan_subjugation CB is this block of code:

        any_demesne_title = {
           limit = {
             higher_tier_than = ROOT
           }
           ROOT = { grant_title = { target = PREV type = invasion } }
           add_pressed_claim = PREV
           set_character_flag = had_higher_titles
         }

You can't set a character flag in a title scope. I believe the set_character_flag should be moved into a different scope. I would recommend rewriting it like this:

if = {
   limit = {
      any_demesne_title = {
         higher_tier_than = ROOT
      }
   }
   set_character_flag = had_higher_titles
   any_demesne_title = {
      limit = {
         higher_tier_than = ROOT
      }
      ROOT = { grant_title = { target = PREV type = invasion } }
      add_pressed_claim = PREV
   }
}

or like this:

any_demesne_title = {
   limit = {
      higher_tier_than = ROOT
   }
   ROOT = { grant_title = { target = PREV type = invasion } }
   add_pressed_claim = PREV
   PREV = { set_character_flag = had_higher_titles }
}

(The first potentially evaluates any_demesne_title twice, the second potentially sets the flag multiple times.)

Edit: Looking more closely at a larger block,

    FROM = {
       piety = -100
       prestige = -100
       
       if = {
         limit = {
           is_reformed_religion = ROOT
           controls_religion = no
         }
         religion = ROOT # Reformed pagans are forced to convert back
       }
       
       custom_tooltip = {
         text = tribal_subjugation_tip
       }
         
       hidden_tooltip = {
         set_defacto_liege = ROOT
         
         any_demesne_title = {
           limit = {
             higher_tier_than = ROOT
           }
           ROOT = { grant_title = { target = PREV type = invasion } }
           add_pressed_claim = PREV
           set_character_flag = had_higher_titles
         }
         
         if = {
           limit = {
             has_character_flag = had_higher_titles
           }
           set_defacto_liege = ROOT
           clr_character_flag = had_higher_titles
           break = yes
         }
         
         any_demesne_title = {
           limit = {
             tier = ROOT
           }
           ROOT = { grant_title = { target = PREV type = invasion } }
           add_pressed_claim = PREV
         }
         set_defacto_liege = ROOT
       }
     }

can be simplified to the following without changing functionality:

    FROM = {
       piety = -100
       prestige = -100
       
       if = {
         limit = {
           is_reformed_religion = ROOT
           controls_religion = no
         }
         religion = ROOT # Reformed pagans are forced to convert back
       }
       
       custom_tooltip = {
         text = tribal_subjugation_tip
       }
         
       hidden_tooltip = {
         any_demesne_title = {
           limit = {
             higher_tier_than = ROOT
           }
           ROOT = { grant_title = { target = PREV type = invasion } }
           add_pressed_claim = FROM
         }  
         any_demesne_title = {
           limit = {
             tier = ROOT
           }
           ROOT = { grant_title = { target = PREV type = invasion } }
           add_pressed_claim = FROM
         }
         set_defacto_liege = ROOT
       }
     }

 

[Leo Larsson]

Hi richvh!

Thanks for reporting this issue&suggestions, going to add it into our database now.
Regards,
Leo