108 Alpha: Industry Tranfer Bug

[Pang Bingxun]

The chinese industry transfer seems to be buggy. It works fine at the first place. But some time after the IC is reduced to zero it grows to a new value much higher than the old value:

Guangzhou: 4 -> 0 -> 8.
Taiyuan: 1 -> 0 -> 5.
Nanjing: 5 -> 0 -> 8.
Jinan: 1 -> 0 -> 3.
Zhengzhou: 2 -> 0 -> 3.

It does only apply where the IC has been reduced to Zero, in Hangzhou the transfer works properly. The same problem appears in the Soviet union.
One might argue it is supposed to strenghten those (early) attacked countries, but i think it was not meant to work this way.

 

[Pang Bingxun]

Hmm, it seems that the reinitialization in the temporarily zero IC Regions occurs always after loading a savegame.

 

[mcganyol]

confirmed. this bug was present in 1.07 also

 

[Pang Bingxun]

The bug seems also to occur in case of river flooting events of china and the soviet union. It seem that the precise procedure is the following one:

1. IC is reduced to zero.
2. The game is saved.
3. The game is loaded.
4. The IC is set to the value you can also find in db\Province.csv.

Editing this file may solve the bug.

 

[Denniss]

I did a quick test with 1.07 and observed the following in the savegame:
The section ic = { location, numbers, etc } is completely removed for the province which had it's IC removed. It should have been set to zero IC instead (which all other provinces with zero IC have).

ic = { 
type = ic 
location = 1314 
size = 0.0000 
current_size = 0.0000 
}

 

[Pang Bingxun]

@Zsar1: 1.08 had solved this bug, but 1.10 did reintroduce it. Taiyuan suddenly has 5 factories instead of 0 after the industry transfer. Similar happened to the other province after going town to zero factories.

 

[Zsar1]

I diagnosed the issue and it is... surprisingly complicated. Will fix with priority, but it will probably take a bit of time.

 

[Pang Bingxun]

Maybe it is now too late but here some more infos to the bug. In the savegame each province has an entry like this:

province = {
   id = 1235
   points = 1
   province_effectivity = 1.0657
   ic = {
     type = ic
     location = 1235
     size = 5.0000
     current_size = 5.0000
     }
   infra = {
     type = infrastructure
     location = 1235
     size = 1.0500
     current_size = 1.0500
     }
   }

For most provinced the entry for ic is zero. So after the industry transfer it should look like this:

province = {
   ic = {
     type = ic
     location = 1235
     size = 0.0000
     current_size = 0.0000
     }

What currently does happen instead is that the entry is removed completely:

province = {
   id = 1235
   points = 1
   province_effectivity = 1.0657
   infra = {
     type = infrastructure
     location = 1235
     size = 1.0500
     current_size = 1.0500
     }
   }

That causes the bug. Once the save is loaded the game loades the ic value from /db/Province.csv, here it would be 8. In order to solve the bug the game must write the entry for zero ic before creating a savefile. If i do this manually via savegame edit the bug does not occur.

 

[Zsar1]

Found a shortcut. Should be fixed in 1.11A02.