[1.3.2]Bugs in War in Heaven

[Risa]

There are lots of bug reports about War in Heaven, so I decided to look at those event scripts and tried to mod those bugs out. I discovered that most bugs reported are from a single cause: War in Heaven scripts are written under assumption that there are only two awaken fallen empires, one awakes first and the second awakes as rival of the first. But in fact there can be a third one, awake to defend against crisis. What makes things worse are that the third uses some same script to awaken as the first, and that the third and the second can be the same FE. Those makes a lot of scripts behave erroneously.

Details:
Both general awaken (fallen_empires_awakening.1, which can lead to war in heaven) and crisis awaken (fallen_empires_awakening.4) call event fallen_empires_awakening.3 to do the job. That event set a country flag sleepers_awake_first_sleeper, which is checked in numerous places in war in heaven events, and nowhere else. So clearly, that country flag shall be moved to fallen_empires_awakening.1.

war_in_heaven.10 (event that determine if one AFE in WiH falls) fails to consider possible existence of crisis AFE. Both its trigger and its action need more checks, such as
OR = {
has_country_flag = sleepers_awake_ancient_rival
has_country_flag = sleepers_awake_first_sleeper
}
That check is also needed in following events: war_in_heaven.13, war_in_heaven.15 (both in applying opinion modifier). war_in_heaven.16 (in declaring war), war_in_heaven.17 (in checking no AFE in WiH).

war_in_heaven.16 need to get NOT = { has_country_flag = sleepers_awake_first_sleeper } replaced with has_country_flag = sleepers_awake_ancient_rival , when select the second AFE in WiH.

Another issue:
Leader of LNAP can leave the federation, yet it does not lose its leader status. There should be an event check and deal with that.


@Wiz , hope your scripts are fixed in 1.4.

 

[Risa]

After some more thoughts, I find an oversight in my opening post as well.
If an FE is chosen both as potential crisis defender and rival of the first AFE, and awake as crisis defender, it will block War in Heaven initiation (war_in_heaven.1). That by itself won't lead to anything wrong, so it's ok to leave it as is. If that blockage is deemed undesirable, we should either make those flags mutual exclusive, or add a separate event to deal with such situation.
Conversely, if such FE awake as WiH combatant, it will also block its awaken as crisis defender. Granted, crisis defender is currently not involved in crisis event chains any further, so that is non-issue right now.

 

[UberWaffe]

Given that I cannot mark a post as helpful multiple times, I'll post here to just say "Well done".
This is some very helpful bug (fix?) reporting.

 

[Risa]

Declaration of WiH (event war_in_heaven.4) steals all subjects from all normal empires. That is not due to error in event script, but rather the bug that AI ignore triggers for conditional option. A separate bug report is filed here: https://forum.paradoxplaza.com/foru...roken-for-ai-or-ai_chance-malfunction.986210/

 

[Risa]

Bump, as it is not yet fixed in 1.4.1.

Also another error: in event war_in_heaven.13, there is code supposedly adding opinion modifier between AFEs and LNAP leader,

   every_country = {
    limit = {
     is_country_type = awakened_fallen_empire
    }
    add_opinion_modifier = { who = from modifier = opinion_non_aligned_league_fe }
    from = { add_opinion_modifier = { who = root modifier = opinion_non_aligned_league_fe } }
   }

Since root is LNAP leader and from is the first AFE (this event is called by war_in_heaven.12, which is a country event for the first AFE), the above code is simply not right.

Together with problem mentioned in opening post, this piece of code should be as follow:

   every_country = {
    limit = {
     is_country_type = awakened_fallen_empire
     OR = {
      has_country_flag = sleepers_awake_ancient_rival
      has_country_flag = sleepers_awake_first_sleeper
     }
    }
    add_opinion_modifier = { who = root modifier = opinion_non_aligned_league_fe }
    root = { add_opinion_modifier = { who = prev modifier = opinion_non_aligned_league_fe } }
   }

Yet another problem:
The trigger of event war_in_heaven.14 is missing of this line,
NOT = { has_global_flag = war_in_heaven_ended }
so it can be erroneously triggered even after WiH is over.