1.04: typos in ai file

[Fürstbischof]

ai_jap.txt

Some events use this trigger:

control = { province = 125 data = JAP } # Nanjing

The id of Nanjing is 1235. Although there is also another trigger it seems to be better to correct these typos.

 

[Denniss]

Thanks for finding this - something taken over from Armageddon, even persistent in 1.3b3. I reported it there as well.

 

[Fürstbischof]

Thanks for finding this - something taken over from Armageddon, even persistent in 1.3b3. I reported it there as well.

It was a pleasure for me. And ofc hard work. ;-)

1.3b3? Are they really working on a third 1.3 beta patch?

 

[Denniss]

Was not officially called 1.3b3 but I'd say it is. Consists of the large file collection in the 1.3b2 package and the smaller data file upgrade released some months ago.

 

[Balesir]

Thanks for pointing this out from me, too - a fixed version of the file is in for inclusion in AoD patch 1.05.

I had already changed this file to support some Sino-Japanese war changes, so I'm mortified I missed it!

 

[Fürstbischof]

Thanks for pointing this out from me, too - a fixed version of the file is in for inclusion in AoD patch 1.05.

I had already changed this file to support some Sino-Japanese war changes, so I'm mortified I missed it!

Take it easy!

As you have already done some changes to this file, it might be too late to ask, but I'd favour if you could add some remarks to the end of each modified/updated file so that you can see at first glance which changes have been made. This would allow modders to keep their own files updated more easily. Since I'm right now in the middle of adapting all AOD events to the E3 map, which is a bigger task than I originally thought, I can tell you that after this torture I'm afraid of each undocumented change in any (especially larger) file.