[Modding] Consolidate building allow-conditions

[Bosparan]

Hello,

I do quite a bit of modding, but since this is a feature request / suggestion, I suppose putting it here would be appropriate.

The Issue
One of the things that has bothered me for quite some time now is this:
Since the introduction of habitats and machine empires, the conditions on what building you are allowed to place have become quite complex, hard to read and probably also take a fair bit of calculation time.

Here's an example block:

potential = {
    planet = {
        NOT = { is_planet_class = pc_habitat } 
    }
} 

allow = {
    if = {
        limit = {
            owner = {
                NOT = { has_authority = auth_machine_intelligence }
            }
        }
        custom_tooltip = {
            text = "requires_building_capital_2"
            planet = {
                OR = {
                    has_building = "building_capital_2"
                    has_building = "building_capital_3"
                }
            }
        }
    }
    if = {
        limit = {
            owner = { has_authority = auth_machine_intelligence }
        }
        custom_tooltip = {
            text = "requires_building_machine_capital_2"
            planet = {
                OR = {
                    has_building = "building_machine_capital_2"
                    has_building = "building_machine_capital_3"
                }
            }
        }
    }
}

Almost every single building in the entire game has this condition block, the only difference being the actual capital level.

The Proposal
Add two properties to a colony:

• colony_type : Indicates what building set should be available (Currently: PlanetBiologic, PlanetMachine and Habitat)
• capital_level : Indicates the planetary capital level (irrespective of whether it's a machine empire or one of these flabby fleshies' ones)

This would allow reducing this entire vast code block above to this:

potential = {
    colony_type = { PlanetBiologic PlanetMachine }
} 

allow = {
    capital_level = 2
}

I'm sure that would be faster to process.
It would certainly make building modding easier to write and easier to read.

Any thoughts? Opinions?
Cheers,
Bosparan