Reinforcing unit not selected based on attributes

[bitmode]

First reported: 1.10.3

DLC/mods: none

CUnit::GetPriorityRating() always returns 0.000, although judging by the implementation it is supposed to rate divisions based on their org and HP. As a result most steps in CLandCombatant::GetBestReserve are rendered useless.

Reproduction steps:

• reinforce a battle with divisions having different HP/org levels

Expected: The unit with the best HP/org eventually reinforces
Actual: The first unit in the reserve list reinforces

 

[el nora]

Is that, as it reads, hp over org? or is it some other function of hp and org?

 

[Haresus]

This is a pretty significant bug that harms the core function of the game's combat system and I hope it gets fixed.

 

[bitmode]

Is that, as it reads, hp over org? or is it some other function of hp and org?

It was just meant as "some calculation based on at least HP and Org". Whatever the intended function is, it was optimized away by the compiler.